From: Matthew Wilcox <matthew@wil.cx>
To: Alex Chiang <achiang@hp.com>, Gary Hade <garyhade@us.ibm.com>,
Greg KH <greg@kroah.com>,
gregkh@suse.de, kristen.c.accardi@intel.com, lenb@kernel.org,
rick.jones2@hp.com, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz,
kaneshige.kenji@jp.fujitsu.com,
pcihpd-discuss@lists.sourceforge.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/5] Construct one fakephp slot per pci slot
Date: Wed, 14 Nov 2007 13:12:47 -0700 [thread overview]
Message-ID: <20071114201246.GZ17785@parisc-linux.org> (raw)
In-Reply-To: <20071114193729.GC25002@ldl.fc.hp.com>
On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang wrote:
> Register one slot per slot, rather than one slot per function.
> Change the name of the slot to fake%d instead of the pci address.
> +#define SLOT_NAME_SIZE KOBJ_NAME_LEN
Defined, then never used ... how about s/KOBJ_NAME_LEN/8/, then use
SLOT_NAME_SIZE throughout?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-11-14 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 19:36 [PATCH 0/5, v2] Physical PCI slot objects Alex Chiang
2007-11-14 19:37 ` [PATCH 1/5] Remove path attribute from sgi_hotplug Alex Chiang
2007-11-14 19:37 ` [PATCH 2/5] Construct one fakephp slot per pci slot Alex Chiang
2007-11-14 20:12 ` Matthew Wilcox [this message]
2007-11-14 20:55 ` Alex Chiang
2007-11-15 11:57 ` Rolf Eike Beer
2007-11-15 17:40 ` Alex Chiang
2007-11-14 21:04 ` Alex Chiang
2007-11-14 19:37 ` [PATCH 3/5] Introduce pci_slot Alex Chiang
2007-11-14 19:38 ` [PATCH 4/5] Add pci_slot_add_hotplug() Alex Chiang
2007-11-14 19:39 ` [PATCH 5/5] ACPI PCI slot detection driver Alex Chiang
2007-11-15 0:39 ` [PATCH 0/5, v2] Physical PCI slot objects Gary Hade
-- strict thread matches above, loose matches on Subject: below --
2007-11-13 0:08 [PATCH 0/5][RFC] " Alex Chiang
2007-11-13 0:13 ` [PATCH 2/5] Construct one fakephp slot per pci slot Alex Chiang
2007-11-13 19:48 ` Linas Vepstas
2007-11-13 19:52 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114201246.GZ17785@parisc-linux.org \
--to=matthew@wil.cx \
--cc=achiang@hp.com \
--cc=garyhade@us.ibm.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox