Re: [patch 5/8] Immediate Values - x86 Optimization

Rusty Russell
2007-11-15T03:08:50Z

On Wednesday 14 November 2007 05:58:05 Mathieu Desnoyers wrote:
> x86 optimization of the immediate values which uses a movl with code
> patching to set/unset the value used to populate the register used as
> variable source.

For the record, I think the patching code gross overkill.

A stop_machine (or lightweight variant using IPI) would be sufficient and
vastly simpler. Trying to patch NMI handlers while they're running is
already crazy.

I'd keep this version up your sleeve for they day when it's needed.

Rusty.