public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, bunk@kernel.org,
	Patrick McHardy <kaber@trash.net>,
	"David S. Miller" <davem@davemloft.net>
Subject: [patch 13/23] Fix SET_VLAN_INGRESS_PRIORITY_CMD error return.
Date: Wed, 14 Nov 2007 22:20:44 -0800	[thread overview]
Message-ID: <20071115062044.GN8282@kroah.com> (raw)
In-Reply-To: <20071115061806.GA8282@kroah.com>

[-- Attachment #1: fix-set_vlan_ingress_priority_cmd-error-return.patch --]
[-- Type: text/plain, Size: 1305 bytes --]

-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Patrick McHardy <kaber@trash.net>

patch fffe470a803e7f7b74c016291e542a0162761209 in mainline.

[VLAN]: Fix SET_VLAN_INGRESS_PRIORITY_CMD ioctl

Based on report and patch by Doug Kehn <rdkehn@yahoo.com>:

vconfig returns the following error when attempting to execute the
set_ingress_map command:

vconfig: socket or ioctl error for set_ingress_map: Operation not permitted

In vlan.c, vlan_ioctl_handler for SET_VLAN_INGRESS_PRIORITY_CMD
sets err = -EPERM and calls vlan_dev_set_ingress_priority.
vlan_dev_set_ingress_priority is a void function so err remains
at -EPERM and results in the vconfig error (even though the ingress
map was set).

Fix by setting err = 0 after the vlan_dev_set_ingress_priority call.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/8021q/vlan.c |    1 +
 1 file changed, 1 insertion(+)

--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -744,6 +744,7 @@ static int vlan_ioctl_handler(void __use
 		vlan_dev_set_ingress_priority(dev,
 					      args.u.skb_priority,
 					      args.vlan_qos);
+		err = 0;
 		break;
 
 	case SET_VLAN_EGRESS_PRIORITY_CMD:

-- 

  parent reply	other threads:[~2007-11-15  6:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071115055238.692814352@mini.kroah.org>
2007-11-15  6:18 ` [patch 00/23] 2.6.23-stable review, network changes Greg KH
2007-11-15  6:20   ` [patch 01/23] mac80211: filter locally-originated multicast frames Greg KH
2007-11-15  6:20   ` [patch 02/23] mac80211: Improve sanity checks on injected packets Greg KH
2007-11-15  6:20   ` [patch 03/23] Add get_unaligned to ieee80211_get_radiotap_len Greg KH
2007-11-15  6:20   ` [patch 04/23] Fix advertised packet scheduler timer resolution Greg KH
2007-11-15  6:20   ` [patch 05/23] Fix 9P protocol build Greg KH
2007-11-15  6:20   ` [patch 06/23] Fix SKB_WITH_OVERHEAD calculations Greg KH
2007-11-15  6:29     ` Herbert Xu
2007-11-15  7:00       ` David Miller
2007-11-15  7:31         ` Herbert Xu
2007-11-16  0:31           ` [stable] " Greg KH
2007-11-16  2:42             ` David Miller
2007-11-15  6:20   ` [patch 07/23] Fix kernel_accept() return handling Greg KH
2007-11-15  6:20   ` [patch 08/23] softmac: fix wext MLME request reason code endianness Greg KH
2007-11-15  6:20   ` [patch 09/23] Fix error returns in sys_socketpair() Greg KH
2007-11-15  6:20   ` [patch 10/23] Fix TEQL oops Greg KH
2007-11-15  6:20   ` [patch 11/23] Fix endianness bug in U32 classifier Greg KH
2007-11-15  6:20   ` [patch 12/23] Fix VLAN address syncing Greg KH
2007-11-15  6:20   ` Greg KH [this message]
2007-11-15  6:20   ` [patch 14/23] Fix crypto_alloc_comp() error checking Greg KH
2007-11-15  6:20   ` [patch 15/23] Fix netlink timeouts Greg KH
2007-11-15  6:20   ` [patch 16/23] NETFILTER: nf_conntrack_tcp: fix connection reopening Greg KH
2007-11-15  6:20   ` [patch 17/23] ieee80211: fix TKIP QoS bug Greg KH
2007-11-15  6:21   ` [patch 18/23] mac80211: reorder association debug output Greg KH
2007-11-15  6:21   ` [patch 19/23] mac80211: store channel info in sta_bss_list Greg KH
2007-11-15  6:21   ` [patch 20/23] mac80211: store SSID " Greg KH
2007-11-15  6:21   ` [patch 21/23] mac80211: honor IW_SCAN_THIS_ESSID in siwscan ioctl Greg KH
2007-11-15  6:21   ` [patch 22/23] mac80211: only honor IW_SCAN_THIS_ESSID in STA, IBSS, and AP modes Greg KH
2007-11-15  6:21   ` [patch 23/23] mac80211: make ieee802_11_parse_elems return void Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071115062044.GN8282@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@kernel.org \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jmforbes@linuxtx.org \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox