Re: [patch 08/16] skge: fix ram buffer size calculation

Stephen Hemminger
2007-11-15T16:29:38Z

Linus Torvalds wrote:
> On Wed, 14 Nov 2007, Greg KH wrote:
>
>> -stable review patch. If anyone has any objections, please let us know.
>>
>> ------------------
>> From: Stephen Hemminger <shemminger@linux-foundation.org>
>>
>> patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline.
>>
>> This fixes problems with transmit hangs on older fiber based SysKonnect boards.
>>
>> Adjust ram buffer sizing calculation to make it correct on all boards
>> and make it like the code in sky2 driver.
>>
>
> This one is getting reverted in mainline in about five minutes (unless I
> find an email from Stephen to address the reported regression - I haven't
> gone through all my emails yet), so I don't think it should make it into
> stable.
>
> Linus
>
I can't reproduce the users problem with the hardware I have. And
without the patch the dual
port board doesn't work. So it is a question of regression, versus
fixing pre-existing bugs.
I am okay with reverting the patch, as a temporary state, but concerned
with how
to make progress in fixing this.