public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Dave Airlie <airlied@redhat.com>
Subject: [patch 35/40] radeon: set the address to access the GART table on the CPU side correctly
Date: Wed, 14 Nov 2007 22:45:48 -0800	[thread overview]
Message-ID: <20071115064548.GJ19218@kroah.com> (raw)
In-Reply-To: <20071115064302.GA19218@kroah.com>

[-- Attachment #1: radeon-set-the-address-to-access-the-gart-table-on-the-cpu-side-correctly.patch --]
[-- Type: text/plain, Size: 1812 bytes --]


-stable review patch.  If anyone has any objections, please let us know.

------------------
From: Dave Airlie <airlied@linux.ie>

Upstream as 7fc86860cf73e060ab8ed9763010dfe5b5389b1c

This code relied on the CPU and GPU address for the aperture being the same,
On some r5xx hardware I was playing with I noticed that this isn't always true.
This fixes issues seen on some r400 cards. (bugs.freedesktop.org 9957)

Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/char/drm/radeon_cp.c  |    5 +++--
 drivers/char/drm/radeon_drv.h |    1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

--- a/drivers/char/drm/radeon_cp.c
+++ b/drivers/char/drm/radeon_cp.c
@@ -1679,7 +1679,7 @@ static int radeon_do_init_cp(struct drm_
 			dev_priv->gart_info.bus_addr =
 			    dev_priv->pcigart_offset + dev_priv->fb_location;
 			dev_priv->gart_info.mapping.offset =
-			    dev_priv->gart_info.bus_addr;
+			    dev_priv->pcigart_offset + dev_priv->fb_aper_offset;
 			dev_priv->gart_info.mapping.size =
 			    dev_priv->gart_info.table_size;
 
@@ -2291,7 +2291,8 @@ int radeon_driver_firstopen(struct drm_d
 	if (ret != 0)
 		return ret;
 
-	ret = drm_addmap(dev, drm_get_resource_start(dev, 0),
+	dev_priv->fb_aper_offset = drm_get_resource_start(dev, 0);
+	ret = drm_addmap(dev, dev_priv->fb_aper_offset,
 			 drm_get_resource_len(dev, 0), _DRM_FRAME_BUFFER,
 			 _DRM_WRITE_COMBINING, &map);
 	if (ret != 0)
--- a/drivers/char/drm/radeon_drv.h
+++ b/drivers/char/drm/radeon_drv.h
@@ -293,6 +293,7 @@ typedef struct drm_radeon_private {
 
 	/* starting from here on, data is preserved accross an open */
 	uint32_t flags;		/* see radeon_chip_flags */
+	unsigned long fb_aper_offset;
 } drm_radeon_private_t;
 
 typedef struct drm_radeon_buf_priv {

-- 

  parent reply	other threads:[~2007-11-15  7:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071115062710.885284510@mini.kroah.org>
2007-11-15  6:43 ` [patch 00/40] 2.6.23-stable review, driver (sans network) changes Greg Kroah-Hartman
2007-11-15  6:43   ` [patch 01/40] POWERPC: Fix platinumfb framebuffer Greg Kroah-Hartman
2007-11-15  6:43   ` [patch 02/40] i915: fix vbl swap allocation size Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 03/40] hwmon/w83627hf: Fix setting fan min right after driver load Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 04/40] hwmon/w83627hf: Dont assume bank 0 Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 05/40] hwmon/lm87: Fix a division by zero Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 06/40] hwmon/lm87: Disable VID when it should be Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 07/40] IB/uverbs: Fix checking of userspace object ownership Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 08/40] IB/mthca: Use mmiowb() to avoid firmware commands getting jumbled up Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 09/40] ALSA: hda-codec - Avoid zero NID in line_out_pinsof STAC codecs Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 10/40] ALSA: fix selector unit bug affecting some USB speakerphones Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 11/40] ALSA: Fix build error without CONFIG_HAS_DMA Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 12/40] ALSA: emu10k1 - Fix memory corruption Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 13/40] ALSA: hdsp - Fix zero division Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 14/40] libata: sync NCQ blacklist with upstream Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 15/40] dm delay: fix status Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 16/40] dm: fix thaw_bdev Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 17/40] md: fix an unsigned compare to allow creation of bitmaps with v1.0 metadata Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 18/40] md: raid5: fix clearing of biofill operations Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 19/40] MSI: Use correct data offset for 32-bit MSI in read_msi_msg() Greg Kroah-Hartman
2007-11-15  6:44   ` [patch 20/40] USB: remove USB_QUIRK_NO_AUTOSUSPEND Greg Kroah-Hartman
2007-11-15 15:50     ` Chuck Ebbert
2007-11-15 17:57       ` Alan Stern
2007-11-15  6:45   ` [patch 21/40] usb-gadget-ether: prevent oops caused by error interrupt race Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 22/40] USB: mutual exclusion for EHCI init and port resets Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 23/40] USB: add URB_FREE_BUFFER to permissible flags Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 24/40] USB: usbserial - fix potential deadlock between write() and IRQ Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 25/40] ALSA: hda-codec - Add array terminator for dmic in STAC codec Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 26/40] i4l: Fix random hard freeze with AVM c4 card Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 27/40] i4l: fix random freezes with AVM B1 drivers Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 28/40] ide: fix serverworks.c UDMA regression Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 29/40] ide: Add ide_get_paired_drive() helper Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 30/40] ide: Fix siimage driver accessing beyond array boundary Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 31/40] ide: Fix cs5535 " Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 32/40] hptiop: avoid buffer overflow when returning sense data Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 33/40] Char: rocket, fix dynamic_dev tty Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 34/40] Char: moxa, fix and optimise empty timer Greg Kroah-Hartman
2007-11-15  6:45   ` Greg Kroah-Hartman [this message]
2007-11-15  6:45   ` [patch 36/40] libata: add HTS542525K9SA00 to NCQ blacklist Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 37/40] libata: backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA Greg Kroah-Hartman
2007-11-15  6:45   ` [patch 38/40] libata: backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA, part 2 Greg Kroah-Hartman
2007-11-15  6:46   ` [patch 39/40] ACPI: sleep: Fix GPE suspend cleanup Greg Kroah-Hartman
2007-11-15  6:46   ` [patch 40/40] ACPI: suspend: Wrong order of GPE restore Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071115064548.GJ19218@kroah.com \
    --to=gregkh@suse.de \
    --cc=airlied@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox