Re: [lm-sensors] broken suspend [Was: 2.6.24-rc2-mm1]

Jiri Slaby
2007-11-26T08:57:53Z

On 11/21/2007 01:00 AM, Rafael J. Wysocki wrote:
> On Tuesday, 20 of November 2007, Mark M. Hoffman wrote:
>> commit ce9c7b78c839a6304696d90083eac08baad524ce
>> Author: Mark M. Hoffman <mhoffman@lightlink.com>
>> Date: Tue Nov 20 07:51:50 2007 -0500
>>
>> hwmon: (coretemp) fix suspend/resume hang
>>
>> Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
>
> I'd do it like this:
>
>> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
>> index 5c82ec7..afe2d31 100644
>> --- a/drivers/hwmon/coretemp.c
>> +++ b/drivers/hwmon/coretemp.c
>> @@ -338,10 +338,12 @@ static int coretemp_cpu_callback(struct notifier_block *nfb,
>> switch (action) {
>> case CPU_ONLINE:
>> case CPU_ONLINE_FROZEN:
>> + case CPU_DOWN_FAILED:
>> coretemp_device_add(cpu);
> + case CPU_DOWN_FAILED_FROZEN:
>> break;
>> - case CPU_DEAD:
>> - case CPU_DEAD_FROZEN:
>> + case CPU_DOWN_PREPARE:
>> coretemp_device_remove(cpu);
> + case CPU_DOWN_PREPARE_FROZEN:
>> break;
>> }

Sorry for the delay, this (trimmed version) solves the problem!

thanks,
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University