Re: 2.6.24-rc2-mm1

Gabriel C
2007-11-14T05:33:57Z

Matthew Dharm wrote:
> On Tue, Nov 13, 2007 at 07:49:24PM -0800, Greg KH wrote:
>> Matt, are these the errors you were worried about with the patch we were
>> just talking about tha tis in my tree?
>
> I can't tell from these logs.

There is the dmesg with CONFIG_USB_STORAGE_DEBUG :

http://194.231.229.228/dmesg-2.6.24-rc2-mm1

>
> The key question (in relation to the allow_restart patch) is this: Was
> everything working fine until a START_STOP was sent to the device?
>
> The SCSI layers used to send devices START_STOP to almost every device as
> part of initialization. I think we switched all of that to use
> TEST_UNIT_READY instead.
>
> The patch you've got should re-enable START_STOP to be sent. The SCSI
> layers (I'm told, but haven't verified myself) only send START_STOP if the
> device reports that it needs a startup command.
>
> CONFIG_USB_STORAGE_DEBUG will generate a *lot* of debug output. But, it
> should be pretty easy to see if START_STOP was sent at all, and if it
> caused the problems.
>
> Matt
>
> P.S. Worst case, the issue we're talking about here would only cause the
> device firmware to crash, which would eventually lead to a disconnect.
> That shouldn't have caused the much more severe problems shown in the log
> you sent.
>

Gabriel