From: Ingo Molnar <mingo@elte.hu>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Rusty Russel <rusty@rustcorp.com.au>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
Oleg Nesterov <oleg@tv-sign.ru>,
Paul E McKenney <paulmck@us.ibm.com>,
Richard Gooch <rgooch@atnf.csiro.au>,
Tigran Aivazian <tigran@aivazian.fs.co.uk>,
Shoahua Li <shaohua.li@linux.com>,
Ralf Baechle <ralf@linux-mips.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Nathan Lynch <ntl@pobox.com>, Paul Jackson <pj@sgi.com>,
Christoph Lameter <clameter@sgi.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation
Date: Thu, 15 Nov 2007 16:25:58 +0100 [thread overview]
Message-ID: <20071115152558.GA22599@elte.hu> (raw)
In-Reply-To: <20071115141501.GB28857@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> * Gautham R Shenoy <ego@in.ibm.com> wrote:
>
> > void lock_cpu_hotplug(void)
> > {
> > - struct task_struct *tsk = current;
> > -
> > - if (tsk == recursive) {
> > - static int warnings = 10;
> > - if (warnings) {
> > - printk(KERN_ERR "Lukewarm IQ detected in hotplug locking\n");
> > - WARN_ON(1);
> > - warnings--;
> > - }
> > - recursive_depth++;
>
> i nominate it for a 2.6.24 merge due to it fixing the above
> regression. I've seen regular instances of the "Lukewarm IQ" message.
FYI, i've put these 3 patches into the scheduler git tree and it's
looking very good so far. So unless Andrew or Linus objects to put this
into v2.6.24, or there's serious questions during review, could we merge
it this way?
Ingo
next prev parent reply other threads:[~2007-11-15 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 13:49 [RFC PATCH 0/3] Refcount Based Cpu Hotplug V3 Gautham R Shenoy
2007-11-15 13:51 ` [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation Gautham R Shenoy
2007-11-15 14:15 ` Ingo Molnar
2007-11-15 15:25 ` Ingo Molnar [this message]
2007-11-15 16:05 ` Ingo Molnar
2007-11-20 10:55 ` Gautham R Shenoy
2007-11-15 17:12 ` Oleg Nesterov
2007-11-15 13:52 ` [RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with get_online_cpus() Gautham R Shenoy
2007-11-15 15:37 ` Ralf Baechle DL5RB
2007-11-15 13:53 ` [RFC PATCH 3/3] cpu-hotplug: Replace per-subsystem mutexes " Gautham R Shenoy
2007-11-15 16:36 ` Oleg Nesterov
2007-11-15 18:26 ` Christoph Lameter
2007-11-15 14:13 ` [RFC PATCH 0/3] Refcount Based Cpu Hotplug V3 Ingo Molnar
2007-11-15 18:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115152558.GA22599@elte.hu \
--to=mingo@elte.hu \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=oleg@tv-sign.ru \
--cc=paulmck@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=pj@sgi.com \
--cc=ralf@linux-mips.org \
--cc=rgooch@atnf.csiro.au \
--cc=rusty@rustcorp.com.au \
--cc=shaohua.li@linux.com \
--cc=tigran@aivazian.fs.co.uk \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox