From: Ralf Baechle DL5RB <ralf@linux-mips.org>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Rusty Russel <rusty@rustcorp.com.au>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Oleg Nesterov <oleg@tv-sign.ru>,
Paul E McKenney <paulmck@us.ibm.com>,
Richard Gooch <rgooch@atnf.csiro.au>,
Tigran Aivazian <tigran@aivazian.fs.co.uk>,
Shoahua Li <shaohua.li@linux.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Nathan Lynch <ntl@pobox.com>, Paul Jackson <pj@sgi.com>,
Christoph Lameter <clameter@sgi.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with get_online_cpus()
Date: Thu, 15 Nov 2007 15:37:48 +0000 [thread overview]
Message-ID: <20071115153748.GD4973@linux-mips.org> (raw)
In-Reply-To: <20071115135202.GB15462@in.ibm.com>
On Thu, Nov 15, 2007 at 07:22:02PM +0530, Gautham R Shenoy wrote:
> Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use
> get_online_cpus and put_online_cpus instead as it highlights
> the refcount semantics in these operations.
>
> The new API guarantees protection against the cpu-hotplug operation,
> but it doesn't guarantee serialized access to any of the local data
> structures. Hence the changes needs to be reviewed.
>
> In case of pseries_add_processor/pseries_remove_processor, use
> cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the
> cpu_present_map there.
>
> Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
> ---
> Documentation/cpu-hotplug.txt | 11 ++++++-----
> arch/mips/kernel/mips-mt-fpaff.c | 10 +++++-----
Acked-by: Ralf Baechle <ralf@linux-mips.org>
for the MIPS part.
Ralf
next prev parent reply other threads:[~2007-11-15 15:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 13:49 [RFC PATCH 0/3] Refcount Based Cpu Hotplug V3 Gautham R Shenoy
2007-11-15 13:51 ` [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation Gautham R Shenoy
2007-11-15 14:15 ` Ingo Molnar
2007-11-15 15:25 ` Ingo Molnar
2007-11-15 16:05 ` Ingo Molnar
2007-11-20 10:55 ` Gautham R Shenoy
2007-11-15 17:12 ` Oleg Nesterov
2007-11-15 13:52 ` [RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with get_online_cpus() Gautham R Shenoy
2007-11-15 15:37 ` Ralf Baechle DL5RB [this message]
2007-11-15 13:53 ` [RFC PATCH 3/3] cpu-hotplug: Replace per-subsystem mutexes " Gautham R Shenoy
2007-11-15 16:36 ` Oleg Nesterov
2007-11-15 18:26 ` Christoph Lameter
2007-11-15 14:13 ` [RFC PATCH 0/3] Refcount Based Cpu Hotplug V3 Ingo Molnar
2007-11-15 18:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115153748.GD4973@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ntl@pobox.com \
--cc=oleg@tv-sign.ru \
--cc=paulmck@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=pj@sgi.com \
--cc=rgooch@atnf.csiro.au \
--cc=rusty@rustcorp.com.au \
--cc=shaohua.li@linux.com \
--cc=tigran@aivazian.fs.co.uk \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox