Re: EIP is at device_shutdown+0x32/0x60

[Greg KH <gregkh@suse.de>]

On Thu, Nov 15, 2007 at 09:55:34PM +0900, Yasunori Goto wrote:
> > On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan <adobriyan@sw.ru> wrote:
> > 
> > > Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1
> > > (1) and during 2.6.24 cycle (2):
> > > 
> > > 	kernel_restart
> > > 	sys_reboot
> > > 	[garbage]
> > > Code: 8b 88 a8 00 00 00 85 c9 74 04 89
> > > EIP is at device_shutdown+0x32/0x60
> > 
> > Yes, all my test boxes did that - it's what I referred to in the releaee
> > notes.  Greg is pondering the problem - seem he's the only person who
> > cannot reproduce it ;)
> 
> Fortunately, my ia64 box reproduces this oops "every time". 
> So, I could chase it.
> 
> device_shutdown() function in drivers/base/power/shutdown.c
> is followings.
> -----------
> /**
>  * device_shutdown - call ->shutdown() on each device to shutdown.
>  */
> void device_shutdown(void)
> {
>         struct device * dev, *devn;
> 
>         list_for_each_entry_safe_reverse(dev, devn, &devices_kset->list,
>                                 kobj.entry) {
>                 if (dev->bus && dev->bus->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->bus->shutdown(dev);
>                 } else if (dev->driver && dev->driver->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->driver->shutdown(dev);
>                 }
>         }
> }
> --------
> When oops occured, dev->driver pointed kset_ktype's address,
> and dev->driver->shutdown was the address of bus_type_list.
> So, Oops was caused by "Illegal operation fault".
> kset_ktypes is pointed by system_kset.
> 
> If my understanding is correct, this loop can't distinguish between
> struct device and struct kset, but both are connected in this list,
> right? It may be the cause of this.

Hm, no, it should just be a list of devices for the kset, but I'll go
verify that this is correct.

And yeah, I can duplicate this problem here too...

thanks,

greg k-h