public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] x86: revert X86_HT semantics change
Date: Thu, 15 Nov 2007 19:19:46 +0100	[thread overview]
Message-ID: <20071115181945.GS4250@stusta.de> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711151904300.3112@localhost.localdomain>

On Thu, Nov 15, 2007 at 07:07:11PM +0100, Thomas Gleixner wrote:
> On Thu, 15 Nov 2007, Sam Ravnborg wrote:
> 
> > On Thu, Nov 15, 2007 at 05:17:03PM +0100, Adrian Bunk wrote:
> > > The x86 unification resulted in CONFIG_X86_HT no longer being
> > > set if (X86_32 && MK8).
> > Yup - my bad. I wrongly assumed MK8 was an X86_64 thing.
> > 
> > Thanks for fixing this.
> > > 
> > > After grep'ing through the tree I think the problem is that different 
> > > places have different assumptions about the semantics of CONFIG_X86_HT,
> > > either:
> > > - hyperthreading or
> > > - multicore
> > > and the SCHED_SMT and SCHED_MC dependencies are just one of the 
> > > symptoms.
> > > 
> > > This should be sorted out properly, but until then we should keep the 
> > > 2.6.23 status quo.
> > > 
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> > 
> > I assume Thomas & Co will forward the patch.
> 
> After looking what does what and fixing it. 
> 
> Right now this patch is not a 1:1 replacement of the .23 status quo,
> as it now makes SCHED_SMT and SCHED_HT depend on !MK8 for 64bit.

*searches brown paperbag*

Thanks for spotting, fixed patch below.

>      tglx

cu
Adrian


<--  snip  -->


The x86 unification resulted in CONFIG_X86_HT no longer being
set if (X86_32 && MK8).

After grep'ing through the tree I think the problem is that different
places have different assumptions about the semantics of CONFIG_X86_HT,
either
- hyperthreading or
- multicore

This should be sorted out properly, but until then we should keep the
2.6.23 status quo.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
480a5ae48036f6825a5a111db87da05e298327d6 
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index af1b1ca..5871b44 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -148,7 +148,8 @@ config X86_SMP
 
 config X86_HT
 	bool
-	depends on SMP && !(X86_VISWS || X86_VOYAGER || MK8)
+	depends on SMP
+	depends on (X86_32 && !(X86_VISWS || X86_VOYAGER)) || (X86_64 && !MK8)
 	default y
 
 config X86_BIOS_REBOOT


  reply	other threads:[~2007-11-15 18:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15 16:17 [2.6 patch] x86: revert X86_HT semantics change Adrian Bunk
2007-11-15 18:04 ` Sam Ravnborg
2007-11-15 18:07   ` Thomas Gleixner
2007-11-15 18:19     ` Adrian Bunk [this message]
2007-12-04 13:29       ` Ingo Molnar
2007-12-04 13:55         ` Adrian Bunk
2007-11-15 18:42     ` Sam Ravnborg
2007-11-15 18:48       ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071115181945.GS4250@stusta.de \
    --to=bunk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox