Re: [PATCHv2 2/4] x86&x86-64 support for sys_indirect

Frederik Deweerdt
2007-11-15T19:30:51Z

Hello Ulrich,
On Thu, Nov 15, 2007 at 01:22:31PM -0500, Ulrich Drepper wrote:
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index ee800e7..e4e8a22 100644
> --- /dev/null 2007-09-23 16:36:38.465394704 -0700
> +++ b/include/asm-x86/indirect_32.h 2007-11-15 09:52:47.000000000 -0800
[...]
> +#define INDIRECT_SYSCALL(regs) (regs)->eax
^^^^^
> +
> +#define CALL_INDIRECT(regs) \
> + ({ extern long (*sys_call_table[]) (__u32, __u32, __u32, __u32, __u32, __u32); \
> + sys_call_table[INDIRECT_SYSCALL(regs)->eax] ((regs)->ebx, (regs)->ecx, \
^^^^^-> I take it that ->eax is wrong here?
> + (regs)->edx, (regs)->esi, \
> + (regs)->edi, (regs)->ebp); \
> + })
> +
> +#endif

Regards,
Frederik