From: Rusty Russell <rusty@rustcorp.com.au>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata_sg_setup_one vs ata_sg_setup?
Date: Thu, 15 Nov 2007 23:36:34 +1100 [thread overview]
Message-ID: <200711152336.34708.rusty@rustcorp.com.au> (raw)
In-Reply-To: <473BC620.9020204@gmail.com>
On Thursday 15 November 2007 15:08:00 Tejun Heo wrote:
> Rusty Russell wrote:
> > Hi Jeff,
> >
> > Was looking through libata, and it seems to me that ata_sg_setup is a
> > superset of ata_sg_setup_one. Am I missing something? Seems like it
> > could be simplified.
> >
> > My machine never seems to do an ata_sg_setup_one, so this patch isn't
> > really tested...
>
> I have about the same patch queued here which also kills
> ata_sg_init_one() completely and replaces
> ATA_QCFLAG_SG/ATA_QCFLAG_SINGLE with ATA_QCFLAG_DMAMAP (now a single
> flag). I'll compare your version and mine and see if mine is missing
> something.
>
> Thanks.
Great, thanks for the feedback. I'd guess mine is more likely missing
something than yours though...
Cheers,
Rusty.
prev parent reply other threads:[~2007-11-15 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 4:40 [PATCH] ata_sg_setup_one vs ata_sg_setup? Rusty Russell
2007-11-14 12:25 ` Boaz Harrosh
2007-11-15 4:08 ` Tejun Heo
2007-11-15 12:36 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711152336.34708.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox