From: Bastian Blank <bastian@waldi.eu.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [patch 3/6] sclp: call sclp_init() from start_kernel().
Date: Fri, 16 Nov 2007 16:09:42 +0100 [thread overview]
Message-ID: <20071116150942.GA5748@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20071116143321.502691250@de.ibm.com>
On Fri, Nov 16, 2007 at 03:29:45PM +0100, Martin Schwidefsky wrote:
> #else
> static inline void acpi_early_init(void) { }
> #endif
> +#ifdef CONFIG_S390
> +extern int sclp_init(void);
> +#else
> +static inline int sclp_init(void) {return 0;}
> +#endif
> #ifndef CONFIG_DEBUG_RODATA
> static inline void mark_rodata_ro(void) { }
> #endif
> @@ -643,6 +648,7 @@ asmlinkage void __init start_kernel(void
> check_bugs();
>
> acpi_early_init(); /* before LAPIC and SMP init */
> + sclp_init();
What happens if sclp_init fails? The other early init calls explicitely
returns void and handels the error internal.
Bastian
--
Time is fluid ... like a river with currents, eddies, backwash.
-- Spock, "The City on the Edge of Forever", stardate 3134.0
next prev parent reply other threads:[~2007-11-16 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 14:29 [patch 0/6] Pending patches in the s390 2.6.25 merge queue Martin Schwidefsky
2007-11-16 14:29 ` [patch 1/6] sclp: sysfs interface for SCLP cpi Martin Schwidefsky
2007-11-16 15:08 ` Kay Sievers
2007-11-19 7:29 ` Cornelia Huck
2007-11-19 8:53 ` Martin Schwidefsky
2007-11-16 14:29 ` [patch 2/6] cio: Extend adapter interrupt interface Martin Schwidefsky
2007-11-16 14:29 ` [patch 3/6] sclp: call sclp_init() from start_kernel() Martin Schwidefsky
2007-11-16 15:09 ` Bastian Blank [this message]
2007-11-16 15:39 ` Heiko Carstens
2007-11-16 14:29 ` [patch 4/6] Standby cpu activation/deactivation Martin Schwidefsky
2007-11-16 14:29 ` [patch 5/6] sclp: convert channel path configure code to use sync interface Martin Schwidefsky
2007-11-16 14:29 ` [patch 6/6] kernel: Shutdown Actions Interface Martin Schwidefsky
2007-11-16 15:15 ` Kay Sievers
2007-11-16 17:44 ` Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116150942.GA5748@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox