From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: linux-kernel@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Andi Kleen <andi@firstfloor.org>,
pageexec@freemail.hu, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: [rfc-patch 10/11] Text Edit Lock - x86_32 standardize debug rodata
Date: Fri, 16 Nov 2007 14:57:57 -0500 [thread overview]
Message-ID: <20071116200140.506643132@polymtl.ca> (raw)
In-Reply-To: 20071116195747.448703304@polymtl.ca
[-- Attachment #1: text-edit-lock-i386-standardize-debug-rodata.patch --]
[-- Type: text/plain, Size: 2062 bytes --]
Standardize DEBUG_RODATA, removing special cases for hotplug and kprobes.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Andi Kleen <andi@firstfloor.org>
CC: pageexec@freemail.hu
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/mm/init_32.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
Index: linux-2.6-lttng/arch/x86/mm/init_32.c
===================================================================
--- linux-2.6-lttng.orig/arch/x86/mm/init_32.c 2007-11-13 09:25:29.000000000 -0500
+++ linux-2.6-lttng/arch/x86/mm/init_32.c 2007-11-13 09:45:48.000000000 -0500
@@ -784,28 +784,21 @@ static int noinline do_test_wp_bit(void)
}
#ifdef CONFIG_DEBUG_RODATA
-
void mark_rodata_ro(void)
{
unsigned long start = PFN_ALIGN(_text);
unsigned long size = PFN_ALIGN(_etext) - start;
-#ifndef CONFIG_KPROBES
-#ifdef CONFIG_HOTPLUG_CPU
- /* It must still be possible to apply SMP alternatives. */
- if (num_possible_cpus() <= 1)
-#endif
- {
- change_page_attr(virt_to_page(start),
- size >> PAGE_SHIFT, PAGE_KERNEL_RX);
- printk("Write protecting the kernel text: %luk\n", size >> 10);
- }
-#endif
+ change_page_attr(virt_to_page(start),
+ size >> PAGE_SHIFT, PAGE_KERNEL_RX);
+ printk(KERN_INFO "Write protecting the kernel text: %luk\n",
+ size >> 10);
+
start += size;
size = (unsigned long)__end_rodata - start;
change_page_attr(virt_to_page(start),
size >> PAGE_SHIFT, PAGE_KERNEL_RO);
- printk("Write protecting the kernel read-only data: %luk\n",
+ printk(KERN_INFO "Write protecting the kernel read-only data: %luk\n",
size >> 10);
/*
@@ -816,6 +809,7 @@ void mark_rodata_ro(void)
*/
global_flush_tlb();
}
+
#endif
void free_init_pages(char *what, unsigned long begin, unsigned long end)
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-11-16 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 19:57 [rfc-patch 00/11] Text Edit Lock for 2.6.24-rc2-git5 Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 01/11] Kprobes - use a mutex to protect the instruction pages list Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 02/11] Kprobes - do not use kprobes mutex in arch code Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 03/11] Kprobes - declare kprobe_mutex static Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 04/11] Add INIT_ARRAY() to kernel.h Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 05/11] Text Edit Lock - Architecture Independent Code Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 06/11] Text Edit Lock - Alternative code for x86 Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 07/11] Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2007-11-17 10:17 ` Roel Kluin
2007-11-17 15:02 ` Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 08/11] Text Edit Lock - kprobes x86_32 Mathieu Desnoyers
2007-11-16 19:57 ` [rfc-patch 09/11] Text Edit Lock - kprobes x86_64 Mathieu Desnoyers
2007-11-16 19:57 ` Mathieu Desnoyers [this message]
2007-11-16 19:57 ` [rfc-patch 11/11] Text Edit Lock - x86_64 standardize debug rodata Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116200140.506643132@polymtl.ca \
--to=mathieu.desnoyers@polymtl.ca \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pageexec@freemail.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox