Re: [PATCH]intel-iommu-PMEN support

Andrew Morton
2007-11-20T00:38:44Z

On Fri, 16 Nov 2007 14:39:57 -0800
mark gross <mgross@linux.intel.com> wrote:

> -#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1
> +#define MAX_FAULT_REASON_IDX (ARRAY_SIZE(fault_reason_strings) - 1)

hm. The logic in there looks screwy.

static char *fault_reason_strings[] =
{
"Software",
"Present bit in root entry is clear",
"Present bit in context entry is clear",
"Invalid context entry",
"Access beyond MGAW",
"PTE Write access is not set",
"PTE Read access is not set",
"Next page table ptr is invalid",
"Root table address invalid",
"Context table ptr is invalid",
"non-zero reserved fields in RTP",
"non-zero reserved fields in CTP",
"non-zero reserved fields in PTE",
"Unknown"
};
#define MAX_FAULT_REASON_IDX (ARRAY_SIZE(fault_reason_strings) - 1)

char *dmar_get_fault_reason(u8 fault_reason)
{
if (fault_reason >= MAX_FAULT_REASON_IDX)
return fault_reason_strings[MAX_FAULT_REASON_IDX - 1];
else
return fault_reason_strings[fault_reason];
}

so all invalid fault_reasons will cause us to display "non-zero reserved
fields in PTE".

Why not just do

if (fault_reason >= ARRAY_SIZE(fault_reason_strings))
return "Unknown";
return fault_reason_strings[fault_reason];

?

(might as well make fault_reason_strings[] const, too).