From: Sam Ravnborg <sam@ravnborg.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@tglx.de
Subject: Re: [patch] Printk kernel version in WARN_ON
Date: Sat, 17 Nov 2007 20:42:40 +0100 [thread overview]
Message-ID: <20071117194240.GD8568@uranus.ravnborg.org> (raw)
In-Reply-To: <20071117113501.5e3e0d43@laptopd505.fenrus.org>
On Sat, Nov 17, 2007 at 11:35:01AM -0800, Arjan van de Ven wrote:
> On Sat, 17 Nov 2007 10:46:52 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > by ... not too much at least, gcc ought to be quite good at merging
> > > same-strings into one, so it's just one extra pointer argument
> > >
> >
> > I think I knew that. At 1000 callsites.
>
> ok so how about putting the same into dump_stack() instead? (see below)
> added bonus is that it's now present for all dumps that use
> dump_stack(), not just WARN_ON()
> (the format I copied from the exact line used by oopses)
This solved the "zillion files being rebuild" issue I mentioned.
So from that angle it is better.
And I notice you use the namespace aware helpers to access the
kernelrelease string - I assume this is better than direct use
of UTS_RELEASE.
Sam
next prev parent reply other threads:[~2007-11-17 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 18:15 [patch] Printk kernel version in WARN_ON Arjan van de Ven
2007-11-17 18:27 ` Andrew Morton
2007-11-17 18:39 ` Arjan van de Ven
2007-11-17 18:46 ` Andrew Morton
2007-11-17 19:35 ` Arjan van de Ven
2007-11-17 19:42 ` Sam Ravnborg [this message]
2007-11-21 12:51 ` Pavel Machek
2007-11-18 0:42 ` Ingo Molnar
2007-11-18 0:57 ` Andrew Morton
2007-11-18 1:04 ` Ingo Molnar
2007-11-18 17:18 ` Arjan van de Ven
2007-11-17 19:28 ` Sam Ravnborg
2007-11-17 23:02 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117194240.GD8568@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@tglx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox