Re: [TOMOYO #5 18/18] LSM expansion for TOMOYO Linux.

Tetsuo Handa
2007-11-20T00:04:23Z

Hello.

Paul Moore wrote:
> My apologies, I mistakenly read the following if statement in your patch:
>
> + if (skb == skb_peek(&sk->sk_receive_queue)) {
> + __skb_unlink(skb, &sk->sk_receive_queue);
> + atomic_dec(&skb->users);
> + }
>
> I read the conditional as the following:
>
> + if (skb = skb_peek(&sk->sk_receive_queue)) {
>
> ... which would have caused the problems I was describing. I'm sorry for all
> of the confusion/frustration, you patient explanations are correct; I was
> wrong in this particular case.
No problem.

To everyone:

Are there any remaining worries with skb_recv_datagram()/socket_post_accept()?

If nobody has objection, I'd like to cut these skb_recv_datagram()/socket_post_accept() changes
and submit to -mm tree.

Regards.