From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753997AbXKSMcx (ORCPT ); Mon, 19 Nov 2007 07:32:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752311AbXKSMco (ORCPT ); Mon, 19 Nov 2007 07:32:44 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:49617 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbXKSMcn (ORCPT ); Mon, 19 Nov 2007 07:32:43 -0500 Date: Mon, 19 Nov 2007 05:32:40 -0700 From: Matthew Wilcox To: Benjamin Herrenschmidt Cc: James Bottomley , Linux Kernel list , linux-scsi , Russell King Subject: Re: SCSI breakage on non-cache coherent architectures Message-ID: <20071119123240.GA12494@parisc-linux.org> References: <1195450523.7022.37.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1195450523.7022.37.camel@pasglop> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 19, 2007 at 04:35:23PM +1100, Benjamin Herrenschmidt wrote: > The other one I'm hitting now is that the SCSI layer nowadays embeds the 'nowadays'? It has always been so. > sense_buffer inside the scsi_cmnd structure without any kind of > alignment whatsoever. I've been hitting irregulary is a crash on SCSI command > completion that seems to be related to corruption of the "request" > pointer in struct scsi_cmnd and I think it might be the cause. > I'm now trying to setup a proper repro-case. What other drivers do is DMA to their own allocation and then memcpy to the sense buffer. There is a movement to allocate the sense data as its own sg list, but I don't think that patch has even been posted yet. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."