public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, bunk@kernel.org,
	Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
	"David S. Miller" <davem@davemloft.net>
Subject: [patch 08/26] Fix TEQL oops.
Date: Mon, 19 Nov 2007 10:18:48 -0800	[thread overview]
Message-ID: <20071119181848.GI15425@kroah.com> (raw)
In-Reply-To: <20071119181746.GA15425@kroah.com>

[-- Attachment #1: fix-teql-oops.patch --]
[-- Type: text/plain, Size: 1097 bytes --]

2.6.22-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>

[PKT_SCHED]: Fix OOPS when removing devices from a teql queuing discipline

[ Upstream commit: 4f9f8311a08c0d95c70261264a2b47f2ae99683a ]

tecl_reset() is called from deactivate and qdisc is set to noop already,
but subsequent teql_xmit does not know about it and dereference private
data as teql qdisc and thus oopses.
not catch it first :)

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/sched/sch_teql.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/net/sched/sch_teql.c
+++ b/net/sched/sch_teql.c
@@ -263,6 +263,9 @@ __teql_resolve(struct sk_buff *skb, stru
 static __inline__ int
 teql_resolve(struct sk_buff *skb, struct sk_buff *skb_res, struct net_device *dev)
 {
+	if (dev->qdisc == &noop_qdisc)
+		return -ENODEV;
+
 	if (dev->hard_header == NULL ||
 	    skb->dst == NULL ||
 	    skb->dst->neighbour == NULL)

-- 

  parent reply	other threads:[~2007-11-19 18:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071119181438.617190424@mini.kroah.org>
2007-11-19 18:17 ` [patch 00/26] 2.6.22-stable review Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 01/26] SLUB: Fix memory leak by not reusing cpu_slab Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 02/26] Fix compat futex hangs Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 03/26] x86: fix TSC clock source calibration error Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 04/26] writeback: dont propagate AOP_WRITEPAGE_ACTIVATE Greg Kroah-Hartman
2007-11-19 19:04     ` Hugh Dickins
2007-11-19 23:05       ` [stable] " Greg KH
2007-11-19 18:18   ` [patch 05/26] fix param_sysfs_builtin name length check Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 06/26] NETFILTER: nf_conntrack_tcp: fix connection reopening Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 07/26] fix the softlockup watchdog to actually work Greg Kroah-Hartman
2007-11-19 19:02     ` Ingo Molnar
2007-11-19 23:02       ` [stable] " Greg KH
2007-11-19 18:18   ` Greg Kroah-Hartman [this message]
2007-11-19 18:18   ` [patch 09/26] Fix netlink timeouts Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 10/26] Fix error returns in sys_socketpair() Greg Kroah-Hartman
2007-11-19 18:18   ` [patch 11/26] Fix endianness bug in U32 classifier Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 12/26] Fix crypto_alloc_comp() error checking Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 13/26] ALSA: hdsp - Fix zero division Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 14/26] ALSA: hda-codec - Add array terminator for dmic in STAC codec Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 15/26] forcedeth msi bugfix Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 16/26] hptiop: avoid buffer overflow when returning sense data Greg Kroah-Hartman
2007-11-19 18:38     ` Matthew Wilcox
2007-11-19 23:03       ` [stable] " Greg KH
2007-11-19 18:19   ` [patch 17/26] USB: kobil_sct: trivial backport to fix libct Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 18/26] USB: usbserial - fix potential deadlock between write() and IRQ Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 19/26] USB: mutual exclusion for EHCI init and port resets Greg Kroah-Hartman
2007-11-19 18:41     ` David Brownell
2007-11-19 18:43       ` Greg KH
2007-11-19 19:04       ` Alan Stern
2007-11-19 19:59         ` David Brownell
2007-11-19 22:32           ` David Miller
2007-11-19 22:52             ` Greg KH
2007-11-19 18:19   ` [patch 20/26] i4l: Fix random hard freeze with AVM c4 card Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 21/26] i4l: fix random freezes with AVM B1 drivers Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 22/26] ide: fix serverworks.c UDMA regression Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 23/26] ocfs2: fix write() performance regression Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 24/26] i2c-pasemi: Fix NACK detection Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 25/26] i2c/eeprom: Hide Sony Vaio serial numbers Greg Kroah-Hartman
2007-11-19 18:19   ` [patch 26/26] i2c/eeprom: Recognize VGN as a valid Sony Vaio name prefix Greg Kroah-Hartman
2007-11-19 18:22   ` [patch 00/26] 2.6.22-stable review Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119181848.GI15425@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@kernel.org \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jmforbes@linuxtx.org \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox