From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, devel@openvz.org
Subject: Re: [PATCH 4/4] proc: fix PDE refcounting
Date: Tue, 20 Nov 2007 01:12:26 -0800 [thread overview]
Message-ID: <20071120011226.7167445b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071116151241.GF19517@localhost.sw.ru>
On Fri, 16 Nov 2007 18:12:41 +0300 Alexey Dobriyan <adobriyan@sw.ru> wrote:
> Creating PDEs with refcount 0 and ->deleted flag has problems (see below).
> Switch to usual scheme:
> * PDE is created with refcount 1
> * every de_get does +1
> * every de_put() and remove_proc_entry() do -1
> * once refcnt reaches 0, PDE is freed.
>
> This elegantly fixes at least two followint races (both observed) without new
> locks, without abusing old locks, without spreading lock_kernel():
fs/reiserfs/procfs.c: In function 'r_start':
fs/reiserfs/procfs.c:424: error: 'struct proc_dir_entry' has no member named 'deleted'
prev parent reply other threads:[~2007-11-20 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 15:12 [PATCH 4/4] proc: fix PDE refcounting Alexey Dobriyan
2007-11-20 9:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120011226.7167445b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@sw.ru \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox