Re: [rfc 03/45] Generic CPU operations: Core piece

Christoph Lameter
2007-11-20T20:37:14Z

On Mon, 19 Nov 2007, Mathieu Desnoyers wrote:

> > But (x) is returned to the "caller" of the macro so it should be specially
> > marged.
> >
>
> I don't think that it really matters.. the preprocessor already wraps
> all the ({ }) in a single statement, doesn't it ?

No it does not matter for the preprocessor. It matters for readability
because I want to see that this is the return value.

> Since checkpatch.pl emits a warning when a one liner if() uses brackets,
> I guess compactness of code is preferred to a consistent style.

I wish someone would fix it. Its giving so much false positives that its
useless for me.