Re: [rfc 45/45] Modules: Hack to handle symbols that have a zero value

Mathieu Desnoyers
2007-11-20T03:29:20Z

* Christoph Lameter (clameter@sgi.com) wrote:
> On Mon, 19 Nov 2007, Mathieu Desnoyers wrote:
>
> > * clameter@sgi.com (clameter@sgi.com) wrote:
> > > The module subsystem cannot handle symbols that are zero. It prints out
> > > a message that these symbols are unresolved. Define a constant
> > >
> > > UNRESOLVED
> > >
> > > that is used to hold the value used for unresolved symbols. Set it to 1
> > > (its hopefully unlikely that a symbol will have the value 1). This is necessary
> > > so that the pda variable which is placed at offset 0 of the per cpu
> > > segment is handled correctly.
> > >
> >
> > Wouldn't it be better to simply return a standard ERR_PTR(-ENO....) ?
>
> Good idea. But can you guarantee that this wont clash with an address?
>

linux/err.h assumes that the last page of the address space is never
ever used. Is that a correct assumption ?

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68