public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Ulrich Drepper <drepper@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv4 1/6] actual sys_indirect code
Date: Tue, 20 Nov 2007 08:04:14 +0100	[thread overview]
Message-ID: <20071120070414.GA543@elte.hu> (raw)
In-Reply-To: <200711200653.lAK6rEVB025878@devserv.devel.redhat.com>


cool patchset. Small nit, the series is not bisectable:

> +#include <asm/indirect.h>

> --- kernel/Makefile
> +++ kernel/Makefile
> @@ -9,7 +9,7 @@ obj-y     = sched.o fork.o exec_domain.o panic.o printk.o profile.o \
>  	    rcupdate.o extable.o params.o posix-timers.o \
>  	    kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o \
>  	    hrtimer.o rwsem.o latency.o nsproxy.o srcu.o \
> -	    utsname.o notifier.o
> +	    utsname.o notifier.o indirect.o

indirect.o is built unconditionally, but it wont build at this stage 
because asm/indirect.h is only introduced in later patches. I suspect a 
CONFIG_ARCH_SUPPORTS_INDIRECT_SYSCALLS Kconfig flag, and its use in the 
Makefile ought to do the trick. (it also reduces object size on 
architectures that have no support for indirect syscalls (yet))

	Ingo

  reply	other threads:[~2007-11-20  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-20  6:53 [PATCHv4 1/6] actual sys_indirect code Ulrich Drepper
2007-11-20  7:04 ` Ingo Molnar [this message]
2007-11-20 17:47   ` Zach Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071120070414.GA543@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox