public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, apw@shadowen.org,
	balbir@linux.vnet.ibm.com, Christoph Lameter <clameter@sgi.com>
Subject: Re: mm snapshot broken-out-2007-11-20-01-45 Build Failure mach_apic.h
Date: Tue, 20 Nov 2007 12:31:40 -0800	[thread overview]
Message-ID: <20071120123140.e0e41c90.akpm@linux-foundation.org> (raw)
In-Reply-To: <4742EDA1.3080308@linux.vnet.ibm.com>

On Tue, 20 Nov 2007 19:52:25 +0530
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:

> Hi Andrew,
> 
> The kernel build fails, on one of the machine 
> 
>   CC      arch/x86/mach-generic/summit.o
> In file included from arch/x86/mach-generic/summit.c:16:
> include/asm/mach-summit/mach_apic.h: In function ___target_cpus___:
> include/asm/mach-summit/mach_apic.h:23: error: ___per_cpu__cpu_mask___ undeclared (first use in this function)
> include/asm/mach-summit/mach_apic.h:23: error: (Each undeclared identifier is reported only once
> include/asm/mach-summit/mach_apic.h:23: error: for each function it appears in.)
> include/asm/mach-summit/mach_apic.h:23: warning: type defaults to ___int___ in declaration of ___type name___
> include/asm/mach-summit/mach_apic.h:23: error: invalid type argument of ___unary *___
> make[1]: *** [arch/x86/mach-generic/summit.o] Error 1
> make: *** [arch/x86/mach-generic] Error 2

        return cpumask_of_cpu(0);

Surely do-not-use-stack-to-allocate-cpumask-for-cpumask_of_cpu.patch.

We can't include percpu.h from cpumask.h because cpumask.h already includes
percpu.h.  So basically all users of cpumask_of_cpu() must include both
percpu.h and percpu.h.

akpm:/usr/src/linux-2.6.24-rc3> grep -rl cpumask_of_cpu . | wc -l
105

erp.  I'll drop the patch.

  reply	other threads:[~2007-11-20 20:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-20  9:45 mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded akpm
2007-11-20 11:30 ` Kamalesh Babulal
2007-11-20 13:07   ` Thomas Gleixner
2007-11-20 14:21     ` Thomas Gleixner
2007-11-20 14:34       ` Kamalesh Babulal
2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
2007-11-27  0:59   ` Tony Breeds
2007-11-20 13:29 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 14:02 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 build failer tumbler/snapper Kamalesh Babulal
2007-11-20 13:48   ` Takashi Iwai
2007-11-20 14:22 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure mach_apic.h Kamalesh Babulal
2007-11-20 20:31   ` Andrew Morton [this message]
2007-11-20 14:46 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz -- powerpc panic Andy Whitcroft
2007-11-20 20:35   ` Andrew Morton
2007-11-20 22:23     ` Eric W. Biederman
2007-11-20 14:48 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 Build Failure arch/x86/kernel/pci-gart_64.c Kamalesh Babulal
2007-11-20 15:18 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 20:50   ` Andrew Morton
2007-11-21  1:32     ` David Howells
2007-11-21  2:40       ` Andrew Morton
2007-11-21 12:49         ` David Howells
2007-11-21 16:15     ` David Howells
2007-11-20 20:34 ` Kamalesh Babulal
2007-11-20 20:48   ` Paul Moore
2007-11-20 21:31     ` Paul Moore
2007-11-20 21:18 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure - macro CONFIG_THREAD_ORDER not defined Kamalesh Babulal
2007-11-20 21:41   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071120123140.e0e41c90.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=clameter@sgi.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox