From: Andrew Morton <akpm@linux-foundation.org>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, apw@shadowen.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: mm snapshot broken-out-2007-11-20-01-45 Build Failure - macro CONFIG_THREAD_ORDER not defined
Date: Tue, 20 Nov 2007 13:41:20 -0800 [thread overview]
Message-ID: <20071120134120.745bd5b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <47434F2E.6080007@linux.vnet.ibm.com>
On Wed, 21 Nov 2007 02:48:38 +0530
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> Hi Andrew,
>
> The kernel build fails, with randconfig
>
> CC arch/x86/kernel/asm-offsets.s
> In file included from include/asm/thread_info.h:4,
> from include/linux/thread_info.h:21,
> from include/linux/preempt.h:9,
> from include/linux/spinlock.h:49,
> from include/linux/seqlock.h:29,
> from include/linux/time.h:8,
> from include/linux/stat.h:60,
> from include/linux/module.h:10,
> from include/linux/crypto.h:21,
> from arch/x86/kernel/asm-offsets_64.c:7,
> from arch/x86/kernel/asm-offsets.c:4:
> include/asm/thread_info_64.h: In function ___current_thread_info___:
> include/asm/thread_info_64.h:63: error: ___CONFIG_THREAD_ORDER___ undeclared (first use in this function)
> include/asm/thread_info_64.h:63: error: (Each undeclared identifier is reported only once
> include/asm/thread_info_64.h:63: error: for each function it appears in.)
> include/asm/thread_info_64.h: In function ___stack_thread_info___:
> include/asm/thread_info_64.h:71: error: ___CONFIG_THREAD_ORDER___ undeclared (first use in this function)
> In file included from arch/x86/kernel/asm-offsets_64.c:8,
> from arch/x86/kernel/asm-offsets.c:4:
> include/linux/sched.h: At top level:
> include/linux/sched.h:1527: error: ___CONFIG_THREAD_ORDER___ undeclared here (not in a function)
> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make: *** [prepare0] Error 2
>
> The patch git-x86.patch introduces CONFIG_THREAD_ORDER undefined macro, instead of THREAD_ORDER.
hrm. I suppose this will get us going:
diff -puN include/asm-x86/page_64.h~git-x86-thread_order-borkage include/asm-x86/page_64.h
--- a/include/asm-x86/page_64.h~git-x86-thread_order-borkage
+++ a/include/asm-x86/page_64.h
@@ -9,7 +9,7 @@
#define PAGE_MASK (~(PAGE_SIZE-1))
#define PHYSICAL_PAGE_MASK (~(PAGE_SIZE-1) & __PHYSICAL_MASK)
-#define THREAD_SIZE (PAGE_SIZE << CONFIG_THREAD_ORDER)
+#define THREAD_SIZE (PAGE_SIZE << THREAD_ORDER)
#define CURRENT_MASK (~(THREAD_SIZE-1))
#define EXCEPTION_STACK_ORDER 0
diff -puN include/asm-x86/thread_info_64.h~git-x86-thread_order-borkage include/asm-x86/thread_info_64.h
--- a/include/asm-x86/thread_info_64.h~git-x86-thread_order-borkage
+++ a/include/asm-x86/thread_info_64.h
@@ -80,9 +80,9 @@ static inline struct thread_info *stack_
#endif
#define alloc_thread_info(tsk) \
- ((struct thread_info *) __get_free_pages(THREAD_FLAGS, CONFIG_THREAD_ORDER))
+ ((struct thread_info *) __get_free_pages(THREAD_FLAGS, THREAD_ORDER))
-#define free_thread_info(ti) free_pages((unsigned long) (ti), CONFIG_THREAD_ORDER)
+#define free_thread_info(ti) free_pages((unsigned long) (ti), THREAD_ORDER)
#else /* !__ASSEMBLY__ */
_
prev parent reply other threads:[~2007-11-20 21:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:45 mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded akpm
2007-11-20 11:30 ` Kamalesh Babulal
2007-11-20 13:07 ` Thomas Gleixner
2007-11-20 14:21 ` Thomas Gleixner
2007-11-20 14:34 ` Kamalesh Babulal
2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
2007-11-27 0:59 ` Tony Breeds
2007-11-20 13:29 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 14:02 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 build failer tumbler/snapper Kamalesh Babulal
2007-11-20 13:48 ` Takashi Iwai
2007-11-20 14:22 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure mach_apic.h Kamalesh Babulal
2007-11-20 20:31 ` Andrew Morton
2007-11-20 14:46 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz -- powerpc panic Andy Whitcroft
2007-11-20 20:35 ` Andrew Morton
2007-11-20 22:23 ` Eric W. Biederman
2007-11-20 14:48 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 Build Failure arch/x86/kernel/pci-gart_64.c Kamalesh Babulal
2007-11-20 15:18 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 20:50 ` Andrew Morton
2007-11-21 1:32 ` David Howells
2007-11-21 2:40 ` Andrew Morton
2007-11-21 12:49 ` David Howells
2007-11-21 16:15 ` David Howells
2007-11-20 20:34 ` Kamalesh Babulal
2007-11-20 20:48 ` Paul Moore
2007-11-20 21:31 ` Paul Moore
2007-11-20 21:18 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure - macro CONFIG_THREAD_ORDER not defined Kamalesh Babulal
2007-11-20 21:41 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120134120.745bd5b4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox