From: Andi Kleen <ak@suse.de>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, hpa@zytor.com,
tglx@linutronix.de, "Siddha,
Suresh B" <suresh.b.siddha@intel.com>,
akpm@linux-foundation.org
Subject: Re: [patch][v2] x86, ptrace: support for branch trace store(BTS)
Date: Tue, 20 Nov 2007 13:45:39 +0100 [thread overview]
Message-ID: <200711201345.39580.ak@suse.de> (raw)
In-Reply-To: <029E5BE7F699594398CA44E3DDF55444F3AEA7@swsmsx413.ger.corp.intel.com>
> - the internal buffer interpretation as well as the corresponding
> operations are selected at run-time by hardware detection
> - different processors use different branch record formats
I still think it would be far better if you would switch this over to be table
driven. e.g. define a record that contains offsetof()/sizeof() of the
different formats and use generic functions. That would decrease
code size considerably.
Also those manpages are really needed.
And your patch seems to be word wrapped.
-Andi
next prev parent reply other threads:[~2007-11-20 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 8:20 [patch][v2] x86, ptrace: support for branch trace store(BTS) Metzger, Markus T
2007-11-20 12:45 ` Andi Kleen [this message]
2007-11-21 11:02 ` Metzger, Markus T
2007-11-21 11:40 ` Andi Kleen
2007-11-22 20:06 ` Metzger, Markus T
2007-11-20 15:26 ` dean gaudet
2007-11-20 15:37 ` dean gaudet
2007-11-20 15:49 ` Metzger, Markus T
2007-11-20 15:57 ` Andi Kleen
2007-11-20 15:39 ` Metzger, Markus T
2007-11-20 15:47 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2007-11-21 11:37 Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711201345.39580.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox