From: Christoph Hellwig <hch@infradead.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexey Dobriyan <adobriyan@sw.ru>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, devel@openvz.org,
James Morris <jmorris@namei.org>,
Eric Paris <eparis@parisplace.org>
Subject: Re: [PATCH 1/4] proc: fix NULL ->i_fop oops
Date: Tue, 20 Nov 2007 15:17:31 +0000 [thread overview]
Message-ID: <20071120151731.GA20322@infradead.org> (raw)
In-Reply-To: <1195571105.20910.31.camel@moss-spartans.epoch.ncsc.mil>
On Tue, Nov 20, 2007 at 10:05:05AM -0500, Stephen Smalley wrote:
> > Nice, getting rid of this is a very good step formwards. Unfortunately
> > we have another copy of this junk in
> > security/selinux/selinuxfs.c:sel_remove_entries() which would need the
> > same treatment.
>
> Can't just be dropped completely for selinux - we need a way to drop
> obsolete entries from the prior policy when we load a new policy.
>
> Is the only real problem here the clearing of f_op? If so, we can
> likely remove that from sel_remove_entries() without harm, and fix the
> checks for it to use something more reliable.
f_op removal is the biggest issue. It can't really work and this is the
last instance. But in general having some half-backed attempts at revoke
is never a good idea.
next prev parent reply other threads:[~2007-11-20 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 15:06 [PATCH 1/4] proc: fix NULL ->i_fop oops Alexey Dobriyan
2007-11-19 12:51 ` Christoph Hellwig
2007-11-20 15:05 ` Stephen Smalley
2007-11-20 15:17 ` Christoph Hellwig [this message]
2007-11-20 15:22 ` Stephen Smalley
2007-11-21 14:01 ` [patch 1/1] selinux: do not clear f_op when removing entries Stephen Smalley
2007-11-21 14:13 ` Christoph Hellwig
2007-11-21 21:35 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120151731.GA20322@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox