public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, Greg KH <gregkh@suse.de>,
	David <david@unsolicited.net>,
	Javier Kohen <jkohen@users.sourceforge.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] Soft lockups since stable kernel upgrade to 2.6.23.8
Date: Tue, 20 Nov 2007 09:05:19 -0800	[thread overview]
Message-ID: <20071120170519.GB15954@kroah.com> (raw)
In-Reply-To: <20071120060525.GF20436@elte.hu>

On Tue, Nov 20, 2007 at 07:05:25AM +0100, Ingo Molnar wrote:
> 
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> 
> > Greg KH wrote:
> > > Can you try applying the patch below to see if that solves the problem
> > > for you?
> > >   
> > 
> > I don't think this patch will help; it only has cosmetic changes in
> > addition to the original message printing fix.  I think it also needs
> > change a3b13c23f186ecb57204580cc1f2dbe9c284953a:
> > 
> > diff -r 79f0ea1e0e70 -r 06f060ab58aa kernel/softlockup.c
> 
> yes, it does need the cpu_clock() changes as i mentioned.
> 
>   commit a3b13c23f186ecb57204580cc1f2dbe9c284953a
>   Author: Ingo Molnar <mingo@elte.hu>
>   Date:   Tue Oct 16 23:26:06 2007 -0700
> 
>     softlockup: use cpu_clock() instead of sched_clock()
> 
>     sched_clock() is not a reliable time-source, use cpu_clock() instead.
> 
> but we only have cpu_clock() from v2.6.23 onwards - so we should not 
> apply the original patch to v2.6.22. (we should not have applied your 
> patch that started the mess to begin with - but that's another matter.)

Well, I can easily back that one out, if that is easier than adding 2
more patches to try to fix up the mess here.

Let me know if you feel that would be best.

thanks,

greg k-h

  reply	other threads:[~2007-11-20 17:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-17 18:21 Soft lockups since stable kernel upgrade to 2.6.23.8 Javier Kohen
2007-11-17 19:12 ` [stable] " Greg KH
2007-11-17 20:05   ` David
2007-11-17 20:37     ` Greg KH
2007-11-18  0:34       ` Jeremy Fitzhardinge
2007-11-19 23:22         ` Greg KH
2007-11-20  1:40           ` Jeremy Fitzhardinge
2007-11-20  6:05             ` Ingo Molnar
2007-11-20 17:05               ` Greg KH [this message]
2007-11-20 20:39                 ` Ingo Molnar
2007-11-20 21:03                   ` Greg KH
2007-11-20 21:49                     ` Ingo Molnar
2007-11-20 22:06                       ` Greg KH
2007-11-20 23:15                       ` David Miller
2007-11-20 23:26                         ` Ingo Molnar
2007-11-20 23:52                         ` Greg KH
2007-11-18  0:55       ` Ingo Molnar
2007-11-20  0:30         ` Chuck Ebbert
2007-11-20  6:08           ` Ingo Molnar
2007-11-20 17:04             ` Greg KH
2007-11-17 19:40 ` David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071120170519.GB15954@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@unsolicited.net \
    --cc=gregkh@suse.de \
    --cc=jeremy@goop.org \
    --cc=jkohen@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox