public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Jean Delvare <khali@linux-fr.org>
Subject: [patch 02/29] i2c/eeprom: Recognize VGN as a valid Sony Vaio name prefix
Date: Tue, 20 Nov 2007 10:23:08 -0800	[thread overview]
Message-ID: <20071120182308.GC28611@kroah.com> (raw)
In-Reply-To: <20071120182248.GA28611@kroah.com>

[-- Attachment #1: i2c-eeprom-recognize-vgn-as-a-valid-sony-vaio-name-prefix.patch --]
[-- Type: text/plain, Size: 1720 bytes --]

2.6.23-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Jean Delvare <khali@linux-fr.org>

patch 8b925a3dd8a4d7451092cb9aa11da727ba69e0f0 in mainline.

Recent (i.e. 2005 and later) Sony Vaio laptops have names beginning
with VGN rather than PCG. Update the eeprom driver so that it
recognizes these.

Why this matters: the eeprom driver hides private data from the
EEPROMs it recognizes as Vaio EEPROMs (passwords, serial number...) so
if the driver fails to recognize a Vaio EEPROM as such, the private
data is exposed to the world.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/i2c/chips/eeprom.c |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

--- a/drivers/i2c/chips/eeprom.c
+++ b/drivers/i2c/chips/eeprom.c
@@ -197,12 +197,16 @@ static int eeprom_detect(struct i2c_adap
 		goto exit_kfree;
 
 	/* Detect the Vaio nature of EEPROMs.
-	   We use the "PCG-" prefix as the signature. */
+	   We use the "PCG-" or "VGN-" prefix as the signature. */
 	if (address == 0x57) {
-		if (i2c_smbus_read_byte_data(new_client, 0x80) == 'P'
-		 && i2c_smbus_read_byte(new_client) == 'C'
-		 && i2c_smbus_read_byte(new_client) == 'G'
-		 && i2c_smbus_read_byte(new_client) == '-') {
+		char name[4];
+
+		name[0] = i2c_smbus_read_byte_data(new_client, 0x80);
+		name[1] = i2c_smbus_read_byte(new_client);
+		name[2] = i2c_smbus_read_byte(new_client);
+		name[3] = i2c_smbus_read_byte(new_client);
+
+		if (!memcmp(name, "PCG-", 4) || !memcmp(name, "VGN-", 4)) {
 			dev_info(&new_client->dev, "Vaio EEPROM detected, "
 				"enabling password protection\n");
 			data->nature = VAIO;

-- 

  parent reply	other threads:[~2007-11-20 18:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071120181733.702234406@mini.kroah.org>
2007-11-20 18:22 ` [patch 00/29] 2.6.23-stable review Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 01/29] i2c-pasemi: Fix NACK detection Greg Kroah-Hartman
2007-11-20 18:23   ` Greg Kroah-Hartman [this message]
2007-11-20 18:23   ` [patch 03/29] i2c/eeprom: Hide Sony Vaio serial numbers Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 04/29] drivers/video/ps3fb: fix memset size error Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 05/29] oProfile: oops when profile_pc() returns ~0LU Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 06/29] raid5: fix unending write sequence Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 07/29] knfsd: fix spurious EINVAL errors on first access of new filesystem Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 08/29] nfsd4: recheck for secure ports in fh_verify Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 09/29] dmaengine: fix broken device refcounting Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 10/29] x86: disable preemption in delay_tsc() Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 11/29] reiserfs: dont drop PG_dirty when releasing sub-page-sized dirty file Greg Kroah-Hartman
2007-11-20 18:23   ` [patch 13/29] libata: sata_sis: use correct S/G table size Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 12/29] sata_sis: fix SCR read breakage Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 14/29] ACPI: VIDEO: Adjust current level to closest available one Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 15/29] Fix divide-by-zero in the 2.6.23 scheduler code Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 16/29] geode: Fix not inplace encryption Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 17/29] libcrc32c: keep intermediate crc state in cpu order Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 18/29] i386: avoid temporarily inconsistent pte-s Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 19/29] x86: fix off-by-one in find_next_zero_string Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 20/29] x86: mark read_crX() asm code as volatile Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 21/29] x86: NX bit handling in change_page_attr() Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 22/29] x86: return correct error code from child_rip in x86_64 entry.S Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 23/29] ntp: fix typo that makes sync_cmos_clock erratic Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 24/29] x86: fix freeze in x86_64 RTC update code in time_64.c Greg Kroah-Hartman
2007-11-20 18:24   ` [patch 25/29] softlockup watchdog fixes and cleanups Greg Kroah-Hartman
2007-11-20 18:25   ` [patch 26/29] softlockup: use cpu_clock() instead of sched_clock() Greg Kroah-Hartman
2007-11-20 18:25   ` [patch 27/29] USB: unusual_devs modification for Nikon D200 Greg Kroah-Hartman
2007-11-20 18:25   ` [patch 28/29] USB: Nikon D40X unusual_devs entry Greg Kroah-Hartman
2007-11-20 18:25   ` [patch 29/29] ipw2200: batch non-user-requested scan result notifications Greg Kroah-Hartman
2007-11-20 18:29   ` [patch 00/29] 2.6.23-stable review Greg Kroah-Hartman
2007-11-20 18:23 ` [patch 12/29] sata_sis: fix SCR read breakage Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071120182308.GC28611@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=jmforbes@linuxtx.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox