From: Christoph Hellwig <hch@infradead.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexey Dobriyan <adobriyan@sw.ru>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, devel@openvz.org,
James Morris <jmorris@namei.org>,
Eric Paris <eparis@parisplace.org>
Subject: Re: [patch 1/1] selinux: do not clear f_op when removing entries
Date: Wed, 21 Nov 2007 14:13:47 +0000 [thread overview]
Message-ID: <20071121141347.GA5695@infradead.org> (raw)
In-Reply-To: <1195653696.759.29.camel@moss-spartans.epoch.ncsc.mil>
On Wed, Nov 21, 2007 at 09:01:36AM -0500, Stephen Smalley wrote:
> Do not clear f_op when removing entries since it isn't safe to do.
If this is still safe for selinux I'm fine with it. It also gets rid
of one of them few remaining s_files users which is always good.
Btw, after this patch we should be able to kill all places that check
for a non-zero file->f_op because it should never be non-zero. Of course
we'll need an actual audit first to make sure nothing has been slipping
through.
next prev parent reply other threads:[~2007-11-21 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 15:06 [PATCH 1/4] proc: fix NULL ->i_fop oops Alexey Dobriyan
2007-11-19 12:51 ` Christoph Hellwig
2007-11-20 15:05 ` Stephen Smalley
2007-11-20 15:17 ` Christoph Hellwig
2007-11-20 15:22 ` Stephen Smalley
2007-11-21 14:01 ` [patch 1/1] selinux: do not clear f_op when removing entries Stephen Smalley
2007-11-21 14:13 ` Christoph Hellwig [this message]
2007-11-21 21:35 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121141347.GA5695@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox