[PATCH] PPC: trivial fix of missed increment on counter

[PATCH] PPC: trivial fix of missed increment on counter

[Cyrill Gorcunov]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

This patch does fix missed increment on counter

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Sorry for that nonstandart patch submission - I've only access
to gmail with Internet Explorer on my work. If that is not OK - will resend
the patch today evening with mutt.

[-- Attachment #2: electra_ide.c-missed-inc.diff --]
[-- Type: text/plain, Size: 403 bytes --]

--- a/arc/powerpc/platforms/pasemi/electra_ide.c	Tue Nov 13 03:05:24 2007
+++ b/arc/powerpc/platforms/pasemi/electra_ide.c	Fri Nov 16 10:32:12 2007
@@ -42,7 +42,7 @@
 	np = of_find_compatible_node(NULL, "ide", "electra-ide");
 	i = 0;
 
-	while (np && i < MAX_IFS) {
+	while (np && i++ < MAX_IFS) {
 		memset(r, 0, sizeof(r));
 
 		/* pata_platform wants two address ranges: one for the base registers,

Re: [PATCH] PPC: trivial fix of missed increment on counter

[Cyrill Gorcunov]

On 11/21/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> This patch does fix missed increment on counter
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> Sorry for that nonstandart patch submission - I've only access
> to gmail with Internet Explorer on my work. If that is not OK - will resend
> the patch today evening with mutt.
>
>
Oops - it seems the patch is corrupted a bit. Drop it please - will
resend today evening. Sorry.

Cyrill

Re: [PATCH] PPC: trivial fix of missed increment on counter

[Olof Johansson]

On Wed, Nov 21, 2007 at 01:58:06PM +0300, Cyrill Gorcunov wrote:
> On 11/21/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > This patch does fix missed increment on counter
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> > Sorry for that nonstandart patch submission - I've only access
> > to gmail with Internet Explorer on my work. If that is not OK - will resend
> > the patch today evening with mutt.
> >
> >
> Oops - it seems the patch is corrupted a bit. Drop it please - will
> resend today evening. Sorry.

Thanks for the fix, but please cc the maintainer (me) next time, as well
as the arch list (linuxppc-dev@ozlabs.org)?

That loop could actually even easier be converted to a
for_each_compatible_node() iteration. There's never more than one
interface on the current boards but it's still nicer coding.

Thanks,

-Olof

Re: [PATCH] PPC: trivial fix of missed increment on counter

[Cyrill Gorcunov]

[Olof Johansson - Thu, Nov 22, 2007 at 09:20:29AM -0600]
| On Wed, Nov 21, 2007 at 01:58:06PM +0300, Cyrill Gorcunov wrote:
| > On 11/21/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| > > This patch does fix missed increment on counter
| > >
| > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| > > ---
| > > Sorry for that nonstandart patch submission - I've only access
| > > to gmail with Internet Explorer on my work. If that is not OK - will resend
| > > the patch today evening with mutt.
| > >
| > >
| > Oops - it seems the patch is corrupted a bit. Drop it please - will
| > resend today evening. Sorry.
| 
| Thanks for the fix, but please cc the maintainer (me) next time, as well
| as the arch list (linuxppc-dev@ozlabs.org)?
| 
| That loop could actually even easier be converted to a
| for_each_compatible_node() iteration. There's never more than one
| interface on the current boards but it's still nicer coding.
| 
| Thanks,
| 
| -Olof
| 

Sorry Olof for missing you. Will cc you and a list next time.
I'm trying to convert all for(;;) cycles to for_each_.. macro
now (actually during the convertation I found a few potential NULL
pointer dereferences so they are going first to list as I've done on them).
So as only I have it done I'll send it to a list (and you too ;) Thanks.

		Cyrill