* [RFC/PATCH] Export force_sig_info
@ 2007-11-12 5:36 Jeremy Kerr
2007-11-23 7:41 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Kerr @ 2007-11-12 5:36 UTC (permalink / raw)
To: linux-kernel; +Cc: cbe-oss-dev
This change allows force_sig_info to be called from modules.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
--
Any objections to exporting this symbol? I'm planning to move some
SPU fault-handling code from the kernel to the spufs.ko object.
---
kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6-spufs/kernel/signal.c
===================================================================
--- linux-2.6-spufs.orig/kernel/signal.c
+++ linux-2.6-spufs/kernel/signal.c
@@ -815,6 +815,7 @@ force_sig_info(int sig, struct siginfo *
return ret;
}
+EXPORT_SYMBOL_GPL(force_sig_info);
void
force_sig_specific(int sig, struct task_struct *t)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC/PATCH] Export force_sig_info
2007-11-12 5:36 [RFC/PATCH] Export force_sig_info Jeremy Kerr
@ 2007-11-23 7:41 ` Andrew Morton
2007-11-23 10:30 ` [Cbe-oss-dev] " Christoph Hellwig
2007-11-26 3:56 ` Jeremy Kerr
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Morton @ 2007-11-23 7:41 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: linux-kernel, cbe-oss-dev
On Mon, 12 Nov 2007 16:36:52 +1100 Jeremy Kerr <jk@ozlabs.org> wrote:
> This change allows force_sig_info to be called from modules.
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
>
> --
>
> Any objections to exporting this symbol? I'm planning to move some
> SPU fault-handling code from the kernel to the spufs.ko object.
>
> ---
>
> kernel/signal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6-spufs/kernel/signal.c
> ===================================================================
> --- linux-2.6-spufs.orig/kernel/signal.c
> +++ linux-2.6-spufs/kernel/signal.c
> @@ -815,6 +815,7 @@ force_sig_info(int sig, struct siginfo *
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(force_sig_info);
>
> void
> force_sig_specific(int sig, struct task_struct *t)
Perhaps export it from within a powerpc-specific C file (along with
suitable comment) to prevent people from generally relying upon the export?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Cbe-oss-dev] [RFC/PATCH] Export force_sig_info
2007-11-23 7:41 ` Andrew Morton
@ 2007-11-23 10:30 ` Christoph Hellwig
2007-11-26 3:56 ` Jeremy Kerr
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2007-11-23 10:30 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jeremy Kerr, linux-kernel, cbe-oss-dev
On Thu, Nov 22, 2007 at 11:41:41PM -0800, Andrew Morton wrote:
> Perhaps export it from within a powerpc-specific C file (along with
> suitable comment) to prevent people from generally relying upon the export?
Yes, please. I don't like this beeing exported at all.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC/PATCH] Export force_sig_info
2007-11-23 7:41 ` Andrew Morton
2007-11-23 10:30 ` [Cbe-oss-dev] " Christoph Hellwig
@ 2007-11-26 3:56 ` Jeremy Kerr
1 sibling, 0 replies; 4+ messages in thread
From: Jeremy Kerr @ 2007-11-26 3:56 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, cbe-oss-dev
Hi Andrew,
> Perhaps export it from within a powerpc-specific C file (along with
> suitable comment) to prevent people from generally relying upon the
> export?
Even better, I'll export it from a Cell-specific C file. I'll follow
this up in my own spufs series for .25.
Cheers,
Jeremy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-26 3:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-12 5:36 [RFC/PATCH] Export force_sig_info Jeremy Kerr
2007-11-23 7:41 ` Andrew Morton
2007-11-23 10:30 ` [Cbe-oss-dev] " Christoph Hellwig
2007-11-26 3:56 ` Jeremy Kerr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox