From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755035AbXKVXam (ORCPT ); Thu, 22 Nov 2007 18:30:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751143AbXKVXac (ORCPT ); Thu, 22 Nov 2007 18:30:32 -0500 Received: from mu-out-0910.google.com ([209.85.134.184]:6889 "EHLO mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbXKVXab convert rfc822-to-8bit (ORCPT ); Thu, 22 Nov 2007 18:30:31 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=IFOZL9JlsAMfdwnix7GvjyTPx5W738B2q25cj+SVBaqRGG1tZuqyqzX75Z7GH2i9aGpzBxCyBWtJOB1ukC/tcsoma8iRCZtuZpBWQ6uR+PHS2j568Nx1jHTRiAWocdxD5BqsiJmIaXENm0T4sBIF9USGIX9lgQoq5Q8ycnP/jxw= From: Maxim Levitsky To: Linux Netdev List Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state Date: Fri, 23 Nov 2007 01:30:15 +0200 User-Agent: KMail/1.9.6 Cc: LKML References: <200711230129.02570.maximlevitsky@gmail.com> In-Reply-To: <200711230129.02570.maximlevitsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline Message-Id: <200711230130.15939.maximlevitsky@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >>From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001 From: Maxim Levitsky Date: Fri, 23 Nov 2007 01:15:36 +0200 Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state Accidently I reversed the order of pci_save_state and pci_set_power_state in .suspend()/.resume() callbacks Signed-off-by: Maxim Levitsky --- drivers/net/tulip/dmfe.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tulip/dmfe.c b/drivers/net/tulip/dmfe.c index 390d02d..9d199b0 100644 --- a/drivers/net/tulip/dmfe.c +++ b/drivers/net/tulip/dmfe.c @@ -2118,8 +2118,8 @@ static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state) pci_enable_wake(pci_dev, PCI_D3cold, 1); /* Power down device*/ - pci_set_power_state(pci_dev, pci_choose_state (pci_dev,state)); pci_save_state(pci_dev); + pci_set_power_state(pci_dev, pci_choose_state (pci_dev,state)); return 0; } @@ -2129,8 +2129,8 @@ static int dmfe_resume(struct pci_dev *pci_dev) struct net_device *dev = pci_get_drvdata(pci_dev); u32 tmp; - pci_restore_state(pci_dev); pci_set_power_state(pci_dev, PCI_D0); + pci_restore_state(pci_dev); /* Re-initilize DM910X board */ dmfe_init_dm910x(dev); -- 1.5.3.4