From: Ingo Molnar <mingo@elte.hu>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org, Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] Don't forget to unlock uids_mutex on error paths
Date: Fri, 23 Nov 2007 14:52:31 +0100 [thread overview]
Message-ID: <20071123135231.GA13681@elte.hu> (raw)
In-Reply-To: <20071123131250.GA5771@linux.vnet.ibm.com>
* Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:
> On Wed, Nov 21, 2007 at 01:49:33PM +0300, Pavel Emelyanov wrote:
> > The commit
> >
> > commit 5cb350baf580017da38199625b7365b1763d7180
> > Author: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> > Date: Mon Oct 15 17:00:14 2007 +0200
> >
> > sched: group scheduling, sysfs tunables
> >
> > introduced the uids_mutex and the helpers to lock/unlock it.
> > Unfortunately, the error paths of alloc_uid() were not patched
> > to unlock it.
oops!
> Thanks for catching it. Looks good to me. Ingo, could you please pick
> these up?
yep - added.
Ingo
prev parent reply other threads:[~2007-11-23 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 10:49 [PATCH 1/2] Don't forget to unlock uids_mutex on error paths Pavel Emelyanov
2007-11-23 13:12 ` Dhaval Giani
2007-11-23 13:52 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123135231.GA13681@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vatsa@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox