From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 9/9] Clean up open coded inode dirty checks
Date: Fri, 23 Nov 2007 18:02:39 +0000 [thread overview]
Message-ID: <20071123180239.GA13229@infradead.org> (raw)
In-Reply-To: <20071122004422.GO114266761@sgi.com>
> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip)
> +{
> + return (((ip->i_itemp == NULL) ||
> + !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
> + (ip->i_update_core == 0));
> +}
Can we please get rid of this useless STATIC_INLINE junk? It's really
hurting my eyes. As does to a lesser extent the verbose style of this
function. This should be something like:
static inline int xfs_inode_clean(struct xfs_inode *ip)
{
return (!ip->i_itemp ||
!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
!ip->i_update_core;
}
next prev parent reply other threads:[~2007-11-23 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 0:44 [PATCH 9/9] Clean up open coded inode dirty checks David Chinner
2007-11-23 18:02 ` Christoph Hellwig [this message]
2007-11-23 18:16 ` Jan Engelhardt
2007-11-23 19:47 ` Joe Perches
2007-11-23 20:16 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123180239.GA13229@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox