public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbou@mail.ru>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] power_supply_{leds,sysfs}.c should #include "power_supply.h"
Date: Mon, 26 Nov 2007 02:19:00 +0300	[thread overview]
Message-ID: <20071125231900.GA19266@zarina> (raw)
In-Reply-To: <20071105170745.GU12045@stusta.de>

On Mon, Nov 05, 2007 at 06:07:45PM +0100, Adrian Bunk wrote:
> Every file should include the headers containing the prototypes for
> its global functions.

Applied to battery-2.6.git, thanks.

p.s.
Sorry for the delay, I've not been Cc'ed, so I've found out about
that patch by pure chance (through looking in the -mm series).

> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
>  drivers/power/power_supply_leds.c  |    2 ++
>  drivers/power/power_supply_sysfs.c |    2 ++
>  2 files changed, 4 insertions(+)
> 
> e34cc994731ec9102bf5b1c7d6585c0aa87d1fa2 
> diff --git a/drivers/power/power_supply_leds.c b/drivers/power/power_supply_leds.c
> index 7f8f359..80ca288 100644
> --- a/drivers/power/power_supply_leds.c
> +++ b/drivers/power/power_supply_leds.c
> @@ -12,6 +12,8 @@
>  
>  #include <linux/power_supply.h>
>  
> +#include "power_supply.h"
> +
>  /* Battery specific LEDs triggers. */
>  
>  static void power_supply_update_bat_leds(struct power_supply *psy)
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 249f61b..e8ad1fd 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -14,6 +14,8 @@
>  #include <linux/ctype.h>
>  #include <linux/power_supply.h>
>  
> +#include "power_supply.h"
> +
>  /*
>   * This is because the name "current" breaks the device attr macro.
>   * The "current" word resolves to "(get_current())" so instead of
> 

-- 
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2

      reply	other threads:[~2007-11-25 23:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 17:07 [2.6 patch] power_supply_{leds,sysfs}.c should #include "power_supply.h" Adrian Bunk
2007-11-25 23:19 ` Anton Vorontsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071125231900.GA19266@zarina \
    --to=cbou@mail.ru \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox