From: "Sébastien Dugué" <sebastien.dugue@bull.net>
To: "peerchen" <peerchen@gmail.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"akpm" <akpm@linux-foundation.org>, "pchen" <pchen@nvidia.com>,
"acurrid" <acurrid@nvidia.com>,
mchan@broadcom.com
Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform
Date: Mon, 26 Nov 2007 10:43:29 +0100 [thread overview]
Message-ID: <20071126104329.34870fe8@bull.net> (raw)
In-Reply-To: <200711251121445151346@gmail.com>
On Sun, 25 Nov 2007 11:21:48 +0800 "peerchen" <peerchen@gmail.com> wrote:
> According to the HyperTransport spec, 'En' indicate if the MSI Mapping is
> active. So it should be set when enable the MSI.
>
Cool, I had a patch that added a quirk to enable MSI Mapping on Broadcom's
HT1000 so that the builtin BCM5706S Gigabit Ethernet would use MSI. This one
looks even cleaner.
As a side note, the bnx2 driver tries to use MSI by default (in the kernel I'm
using - 2.6.21.5-rt10) and falls back to INTx if no interrupt is received within
a reasonable amount of time. If the HT MSI Mapping is not enabled beforehand,
the first MSI message (before reverting to INTx) is not trapped by the bridge
and lands in memory thus corrupting what is there at that time. In my case
it's the mapcount of a struct page in the freelist which is overwritten with
the MSI message.
Sébastien.
next prev parent reply other threads:[~2007-11-26 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 3:21 [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform peerchen
2007-11-25 10:21 ` Prakash Punnoor
2007-11-27 8:00 ` Andrew Morton
2007-11-26 9:43 ` Sébastien Dugué [this message]
2007-11-27 8:13 ` Andrew Morton
[not found] <fa.o8FrHkCTygSL3HgQ8yHeTr2D3tI@ifi.uio.no>
2007-11-25 18:33 ` Robert Hancock
2007-11-26 4:01 ` Peer Chen
2007-11-26 5:14 ` Andy Currid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126104329.34870fe8@bull.net \
--to=sebastien.dugue@bull.net \
--cc=acurrid@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=pchen@nvidia.com \
--cc=peerchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox