From: Jens Axboe <jens.axboe@oracle.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scatterlist: add more safeguards
Date: Mon, 26 Nov 2007 15:43:26 +0100 [thread overview]
Message-ID: <20071126144326.GC5050@kernel.dk> (raw)
In-Reply-To: <20071126112832.GA9232@htj.dyndns.org>
On Mon, Nov 26 2007, Tejun Heo wrote:
> Add more safeguards to protect against misinterpreting a chain entry
> as a normal scatterlist and vice-versa.
>
> * Make sure the entry isn't a chain when assigning and reading a
> normal sg.
>
> * Clear offset and length when chaining.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> While converting libata to use chained-sg, I felt a bit insecure and
> added a few more safe guards. Feel free to include or ignore them.
Looks sane, thanks Tejun! Will apply it.
--
Jens Axboe
prev parent reply other threads:[~2007-11-26 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 11:28 [PATCH] scatterlist: add more safeguards Tejun Heo
2007-11-26 14:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126144326.GC5050@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox