Re: [patch 11/14] Powerpc: Use generic per cpu

Christoph Lameter
2007-11-28T18:55:00Z

On Wed, 28 Nov 2007, Paul Mackerras wrote:

> Christoph Lameter writes:
>
> > On Wed, 28 Nov 2007, Paul Mackerras wrote:
> >
> > > Did you try both 32-bit (CONFIG_64BIT=n) and 64-bit (CONFIG_64BIT=y)
> > > configurations? The paca only exists in 64-bit kernels.
> >
> > I build both and there is no dependency on 32bit or 64 bit in
> > include/asm-powerpc/percpu.h. Both access the paca (whatever that is).
>
> Look at line 3 of include/asm-powerpc/percpu.h:
>
> #ifdef __powerpc64__
>
> As far as I can see, after applying your series of patches, I end up
> with an unbalanced #ifdef in include/asm-powerpc/percpu.h. I see 3
> #ifdef/#ifndef, but only two #endifs. It needs another #endif after
> the #endif /* SMP */ to match the #ifdef __powerpc64__. With that
> change it looks OK, since 32-bit uses asm-generic/percpu.h for both
> SMP and UP.

Ahhh.. Ok. Fixed.

Do you know where to get a ppc64 crosscompiler? I
tried to build gcc for ppc64 but the build failed on x86_64.