Re: [patch 05/14] percpu: Use a Kconfig variable to configure arch specific percpu setup

Randy Dunlap
2007-11-27T23:42:10Z

On Mon, 26 Nov 2007 16:14:12 -0800 Christoph Lameter wrote:

> The use of the __GENERIC_PERCPU is a bit problematic since arches
> may want to run their own percpu setup while using the generic
> percpu definitions. Replace it through a kconfig variable.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Andi Kleen <ak@suse.de>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> ---
>
> Index: linux-2.6/arch/ia64/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/ia64/Kconfig 2007-11-26 15:38:56.415112360 -0800
> +++ linux-2.6/arch/ia64/Kconfig 2007-11-26 15:40:10.425862722 -0800
> @@ -75,6 +75,10 @@ config GENERIC_TIME_VSYSCALL
> bool
> default y
>
> +config ARCH_SETS_UP_PER_CPU_AREA
> + bool
> + default y
> +
> config DMI
> bool
> default y

> Index: linux-2.6/arch/sparc64/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/sparc64/Kconfig 2007-11-26 15:38:56.447111936 -0800
> +++ linux-2.6/arch/sparc64/Kconfig 2007-11-26 15:40:10.425862722 -0800
> @@ -66,6 +66,10 @@ config AUDIT_ARCH
> bool
> default y
>
> +config ARCH_SETS_UP_PER_CPU_AREA
> + bool
> + default y

def_bool y
is the preferred form for those 2-liners above...

> +
> config ARCH_NO_VIRT_TO_BUS
> def_bool y
>

---
~Randy