From: tony@bakeyournoodle.com (Tony Breeds)
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, mick@madwifi.org,
netdev@vger.kernel.org, Andy Whitcroft <apw@shadowen.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver
Date: Tue, 27 Nov 2007 11:59:50 +1100 [thread overview]
Message-ID: <20071127005950.GZ24243@bakeyournoodle.com> (raw)
In-Reply-To: <4742DFC3.80305@linux.vnet.ibm.com>
On Tue, Nov 20, 2007 at 06:53:15PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The kernel build fails, with following message
>
> LD drivers/net/wireless/built-in.o
> drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
> (.opd+0x180): multiple definition of `rtl8225z2_rf_init'
> drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
> drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
> /root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple definition of `.rtl8225z2_rf_init'
> drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561: first defined here
> ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
<snip>
The patch below is a little ugly but will allow allyesconfig to work. I
don't know enough about the Realtek devices to make intellegent
suggestions on how to fix this particular problem. Clearly the 2
drivers share a lot of common code so perhaps they can be merged?
I assumed that the RTL8180, is still somewhat WiP based on the commit
message for a2645795713c4374ff2efda960251cdc30b63430 (wireless-2.6.git).
Appologies for the uber long CC line, wasn't sure who can be pruned.
From: Tony Breeds <tony@bakeyournoodle.com>
Temporarily ensure that Realtek 8185 and 8187 aren't compiled together.
These two drivers share a number of common (global) functions. While RTL8180
is still being worked on ensure that it's not built together with the RTL8187
(ie allyseconfig).
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
drivers/net/wireless/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 82e5de7..ab2eac0 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -555,6 +555,7 @@ config USB_ZD1201
config RTL8180
tristate "Realtek 8185 PCI support"
depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
+ depends on !RTL8187
select EEPROM_93CX6
config RTL8187
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2007-11-27 1:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:45 mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded akpm
2007-11-20 11:30 ` Kamalesh Babulal
2007-11-20 13:07 ` Thomas Gleixner
2007-11-20 14:21 ` Thomas Gleixner
2007-11-20 14:34 ` Kamalesh Babulal
2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
2007-11-27 0:59 ` Tony Breeds [this message]
2007-11-20 13:29 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 14:02 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 build failer tumbler/snapper Kamalesh Babulal
2007-11-20 13:48 ` Takashi Iwai
2007-11-20 14:22 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure mach_apic.h Kamalesh Babulal
2007-11-20 20:31 ` Andrew Morton
2007-11-20 14:46 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz -- powerpc panic Andy Whitcroft
2007-11-20 20:35 ` Andrew Morton
2007-11-20 22:23 ` Eric W. Biederman
2007-11-20 14:48 ` [PATCH] mm snapshot broken-out-2007-11-20-01-45 Build Failure arch/x86/kernel/pci-gart_64.c Kamalesh Babulal
2007-11-20 15:18 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
2007-11-20 20:50 ` Andrew Morton
2007-11-21 1:32 ` David Howells
2007-11-21 2:40 ` Andrew Morton
2007-11-21 12:49 ` David Howells
2007-11-21 16:15 ` David Howells
2007-11-20 20:34 ` Kamalesh Babulal
2007-11-20 20:48 ` Paul Moore
2007-11-20 21:31 ` Paul Moore
2007-11-20 21:18 ` mm snapshot broken-out-2007-11-20-01-45 Build Failure - macro CONFIG_THREAD_ORDER not defined Kamalesh Babulal
2007-11-20 21:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127005950.GZ24243@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mick@madwifi.org \
--cc=mm-commits@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox