From: Greg KH <greg@kroah.com>
To: Julia Lawall <julia@diku.dk>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/usb: Drop unnecessary continue
Date: Mon, 26 Nov 2007 22:48:09 -0800 [thread overview]
Message-ID: <20071127064809.GA7571@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711140914360.26019@ask.diku.dk>
On Wed, Nov 14, 2007 at 09:15:16AM +0100, Julia Lawall wrote:
> diff -u -p -b -B a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
> --- a/drivers/usb/host/isp116x-hcd.c 2007-10-22 11:25:24.000000000 +0200
> +++ b/drivers/usb/host/isp116x-hcd.c 2007-11-13 23:14:10.000000000 +0100
> @@ -918,7 +918,6 @@ static int isp116x_hub_status_data(struc
> | RH_PS_OCIC | RH_PS_PRSC)) {
> changed = 1;
> buf[0] |= 1 << (i + 1);
> - continue;
> }
> }
> spin_unlock_irqrestore(&isp116x->lock, flags);
Your email client is eating all the tabs and converting them to spaces,
making these patches very hard to apply.
I've fixed this one up by hand, but please, fix your email client for
future ones.
thanks,
greg k-h
prev parent reply other threads:[~2007-11-27 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 8:15 [PATCH 3/4] drivers/usb: Drop unnecessary continue Julia Lawall
2007-11-27 6:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127064809.GA7571@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox