[PATCH 3/4] drivers/usb: Drop unnecessary continue

[PATCH 3/4] drivers/usb: Drop unnecessary continue

[Julia Lawall]

From: Julia Lawall <julia@diku.dk>

Continue is not needed at the bottom of a loop.

The semantic patch implementing this change is as follows:

@@
@@

for (...;...;...) {
   ...
   if (...) {
     ...
-   continue;
   }
}

Signed-off-by: Julia Lawall <julia@diku.dk>
---

diff -u -p -b -B a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
--- a/drivers/usb/host/isp116x-hcd.c 2007-10-22 11:25:24.000000000 +0200
+++ b/drivers/usb/host/isp116x-hcd.c 2007-11-13 23:14:10.000000000 +0100
@@ -918,7 +918,6 @@ static int isp116x_hub_status_data(struc
  			      | RH_PS_OCIC | RH_PS_PRSC)) {
  			changed = 1;
  			buf[0] |= 1 << (i + 1);
-			continue;
  		}
  	}
  	spin_unlock_irqrestore(&isp116x->lock, flags);
diff -u -p -b -B a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c
--- a/drivers/usb/image/mdc800.c 2007-07-23 11:27:17.000000000 +0200
+++ b/drivers/usb/image/mdc800.c 2007-11-13 23:14:33.000000000 +0100
@@ -479,7 +479,6 @@ static int mdc800_usb_probe (struct usb_
  					irq_interval=intf_desc->endpoint [j].desc.bInterval;
  				}

-				continue;
  			}
  		}
  		if (mdc800->endpoint[i] == -1)

Re: [PATCH 3/4] drivers/usb: Drop unnecessary continue

[Greg KH]

On Wed, Nov 14, 2007 at 09:15:16AM +0100, Julia Lawall wrote:
> diff -u -p -b -B a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
> --- a/drivers/usb/host/isp116x-hcd.c 2007-10-22 11:25:24.000000000 +0200
> +++ b/drivers/usb/host/isp116x-hcd.c 2007-11-13 23:14:10.000000000 +0100
> @@ -918,7 +918,6 @@ static int isp116x_hub_status_data(struc
>   			      | RH_PS_OCIC | RH_PS_PRSC)) {
>   			changed = 1;
>   			buf[0] |= 1 << (i + 1);
> -			continue;
>   		}
>   	}
>   	spin_unlock_irqrestore(&isp116x->lock, flags);

Your email client is eating all the tabs and converting them to spaces,
making these patches very hard to apply.

I've fixed this one up by hand, but please, fix your email client for
future ones.

thanks,

greg k-h