From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759055AbXK0QKg (ORCPT ); Tue, 27 Nov 2007 11:10:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755884AbXK0QK3 (ORCPT ); Tue, 27 Nov 2007 11:10:29 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:48061 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755223AbXK0QK2 (ORCPT ); Tue, 27 Nov 2007 11:10:28 -0500 Date: Mon, 26 Nov 2007 22:48:09 -0800 From: Greg KH To: Julia Lawall Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/4] drivers/usb: Drop unnecessary continue Message-ID: <20071127064809.GA7571@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 14, 2007 at 09:15:16AM +0100, Julia Lawall wrote: > diff -u -p -b -B a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c > --- a/drivers/usb/host/isp116x-hcd.c 2007-10-22 11:25:24.000000000 +0200 > +++ b/drivers/usb/host/isp116x-hcd.c 2007-11-13 23:14:10.000000000 +0100 > @@ -918,7 +918,6 @@ static int isp116x_hub_status_data(struc > | RH_PS_OCIC | RH_PS_PRSC)) { > changed = 1; > buf[0] |= 1 << (i + 1); > - continue; > } > } > spin_unlock_irqrestore(&isp116x->lock, flags); Your email client is eating all the tabs and converting them to spaces, making these patches very hard to apply. I've fixed this one up by hand, but please, fix your email client for future ones. thanks, greg k-h