* [PATCH] [VIDEO]: Complement va_start() with va_end().
@ 2007-11-27 7:06 Richard Knutsson
2007-11-27 9:01 ` WANG Cong
0 siblings, 1 reply; 4+ messages in thread
From: Richard Knutsson @ 2007-11-27 7:06 UTC (permalink / raw)
To: mchehab; +Cc: v4l-dvb-maintainer, linux-kernel, Richard Knutsson
Complement va_start() with va_end().
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Compile-tested on i386 with allyesconfig and allmodconfig.
diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c
index ad02329..996b494 100644
--- a/drivers/media/video/saa5246a.c
+++ b/drivers/media/video/saa5246a.c
@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)
{
unsigned char buf[64];
int v;
- int ct=0;
+ int ct = 0;
va_list argp;
- va_start(argp,t);
+ va_start(argp, t);
- while((v=va_arg(argp,int))!=-1)
- buf[ct++]=v;
+ while ((v = va_arg(argp, int)) != -1)
+ buf[ct++] = v;
+
+ va_end(argp);
return i2c_sendbuf(t, buf[0], ct-1, buf+1);
}
diff --git a/drivers/media/video/saa5249.c b/drivers/media/video/saa5249.c
index 94bb59a..da5ca30 100644
--- a/drivers/media/video/saa5249.c
+++ b/drivers/media/video/saa5249.c
@@ -282,12 +282,14 @@ static int i2c_senddata(struct saa5249_device *t, ...)
{
unsigned char buf[64];
int v;
- int ct=0;
+ int ct = 0;
va_list argp;
va_start(argp,t);
- while((v=va_arg(argp,int))!=-1)
- buf[ct++]=v;
+ while ((v = va_arg(argp, int)) != -1)
+ buf[ct++] = v;
+
+ va_end(argp);
return i2c_sendbuf(t, buf[0], ct-1, buf+1);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [VIDEO]: Complement va_start() with va_end().
2007-11-27 7:06 [PATCH] [VIDEO]: Complement va_start() with va_end() Richard Knutsson
@ 2007-11-27 9:01 ` WANG Cong
2007-11-27 9:21 ` [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes Richard Knutsson
0 siblings, 1 reply; 4+ messages in thread
From: WANG Cong @ 2007-11-27 9:01 UTC (permalink / raw)
To: Richard Knutsson; +Cc: mchehab, v4l-dvb-maintainer, linux-kernel
On Tue, Nov 27, 2007 at 08:06:17AM +0100, Richard Knutsson wrote:
>Complement va_start() with va_end().
>
>Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
>---
>Compile-tested on i386 with allyesconfig and allmodconfig.
>
>
>diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c
>index ad02329..996b494 100644
>--- a/drivers/media/video/saa5246a.c
>+++ b/drivers/media/video/saa5246a.c
>@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)
> {
> unsigned char buf[64];
> int v;
>- int ct=0;
>+ int ct = 0;
> va_list argp;
>- va_start(argp,t);
>+ va_start(argp, t);
Hi, Richard!
These are style fixes, and you did't mention this above. ;)
Thanks.
Cong
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes
2007-11-27 9:01 ` WANG Cong
@ 2007-11-27 9:21 ` Richard Knutsson
2007-11-27 9:52 ` Richard Knutsson
0 siblings, 1 reply; 4+ messages in thread
From: Richard Knutsson @ 2007-11-27 9:21 UTC (permalink / raw)
To: WANG Cong; +Cc: mchehab, v4l-dvb-maintainer, linux-kernel
Complement va_start() with va_end() + minor style fixes in the same function.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Compile-tested on i386 with allyesconfig and allmodconfig.
Thanks to WANG Cong for pointing out the missing 'style fix'-description.
saa5246a.c | 10 ++++++----
saa5249.c | 8 +++++---
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c
index ad02329..996b494 100644
--- a/drivers/media/video/saa5246a.c
+++ b/drivers/media/video/saa5246a.c
@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)
{
unsigned char buf[64];
int v;
- int ct=0;
+ int ct = 0;
va_list argp;
- va_start(argp,t);
+ va_start(argp, t);
- while((v=va_arg(argp,int))!=-1)
- buf[ct++]=v;
+ while ((v = va_arg(argp, int)) != -1)
+ buf[ct++] = v;
+
+ va_end(argp);
return i2c_sendbuf(t, buf[0], ct-1, buf+1);
}
diff --git a/drivers/media/video/saa5249.c b/drivers/media/video/saa5249.c
index 94bb59a..da5ca30 100644
--- a/drivers/media/video/saa5249.c
+++ b/drivers/media/video/saa5249.c
@@ -282,12 +282,14 @@ static int i2c_senddata(struct saa5249_device *t, ...)
{
unsigned char buf[64];
int v;
- int ct=0;
+ int ct = 0;
va_list argp;
va_start(argp,t);
- while((v=va_arg(argp,int))!=-1)
- buf[ct++]=v;
+ while ((v = va_arg(argp, int)) != -1)
+ buf[ct++] = v;
+
+ va_end(argp);
return i2c_sendbuf(t, buf[0], ct-1, buf+1);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes
2007-11-27 9:21 ` [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes Richard Knutsson
@ 2007-11-27 9:52 ` Richard Knutsson
0 siblings, 0 replies; 4+ messages in thread
From: Richard Knutsson @ 2007-11-27 9:52 UTC (permalink / raw)
To: WANG Cong; +Cc: mchehab, v4l-dvb-maintainer, linux-kernel
Please ignore the previous patch. Have resent it, but since my
mail-client (Thunderbird) seem to be having a bad day, I had to use
'sendpatchset' and it can't continue on a thread.
Richard Knutsson
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-27 10:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-27 7:06 [PATCH] [VIDEO]: Complement va_start() with va_end() Richard Knutsson
2007-11-27 9:01 ` WANG Cong
2007-11-27 9:21 ` [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes Richard Knutsson
2007-11-27 9:52 ` Richard Knutsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox