From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pierre Ossman <drzeus@drzeus.cx>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Sam Ravnborg <sam@ravnborg.org>,
Marcel Holtmann <marcel@holtmann.org>,
linux-kernel@vger.kernel.org
Subject: Re: m68k build failure
Date: Wed, 28 Nov 2007 09:28:56 +0000 [thread overview]
Message-ID: <20071128092856.GV8181@ftp.linux.org.uk> (raw)
In-Reply-To: <20071128010056.85703a34.akpm@linux-foundation.org>
On Wed, Nov 28, 2007 at 01:00:56AM -0800, Andrew Morton wrote:
> > No the slightest. 12 seems like the correct, padded size. A size of 10 is just weird as the unpadded size is 9 bytes. Could you dump the __mod_sdio_device_table section so we can determine if it is cropped or just oddly padded.
> >
>
> err, I'd rather not. I have no shortage of bugs to be going on with here.
>
> http://userweb.kernel.org/~akpm/cross-compilers/ has the i386->m68k
> cross-compiler which I use.
Eh... m68k has 16bit alignment for unsigned long.
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -343,7 +343,8 @@ struct sdio_device_id {
__u8 class; /* Standard interface or SDIO_ANY_ID */
__u16 vendor; /* Vendor or SDIO_ANY_ID */
__u16 device; /* Device ID or SDIO_ANY_ID */
- kernel_ulong_t driver_data; /* Data private to the driver */
+ kernel_ulong_t driver_data /* Data private to the driver */
+ __attribute__((aligned(sizeof(kernel_ulong_t))));
};
/* SSB core, see drivers/ssb/ */
next prev parent reply other threads:[~2007-11-28 9:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 6:07 m68k build failure Andrew Morton
2007-11-28 8:48 ` Pierre Ossman
2007-11-28 9:00 ` Andrew Morton
2007-11-28 9:28 ` Al Viro [this message]
2007-11-28 12:29 ` Pierre Ossman
2007-11-28 12:34 ` Geert Uytterhoeven
2007-12-01 20:56 ` Pierre Ossman
2007-12-02 11:22 ` Correct types for mod_devicetable.h (was: Re: m68k build failure) Geert Uytterhoeven
2007-12-03 10:02 ` Rusty Russell
2007-12-08 21:58 ` Adrian Bunk
2007-12-09 6:43 ` Jon Masters
2007-12-09 17:10 ` Pierre Ossman
2007-12-12 1:34 ` Rusty Russell
2007-12-09 17:08 ` Pierre Ossman
2007-12-10 18:11 ` Adrian Bunk
2007-12-10 19:12 ` Pierre Ossman
2007-11-29 21:19 ` m68k build failure Andrew Morton
2007-11-30 17:55 ` Adrian Bunk
2007-11-28 9:24 ` Geert Uytterhoeven
2007-11-28 9:27 ` Geert Uytterhoeven
2007-11-28 10:01 ` Pierre Ossman
2007-11-28 10:07 ` Alan Cox
2007-11-28 10:23 ` Andreas Schwab
2007-11-28 9:58 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128092856.GV8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=drzeus@drzeus.cx \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox