From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] Fix hpet wrong values
Date: Wed, 28 Nov 2007 11:40:40 +0100 [thread overview]
Message-ID: <20071128104040.GA20113@elte.hu> (raw)
In-Reply-To: <20071128103851.GA19701@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> ---------------->
> e09e9089131ca0227a716aee143f49d084977e32 is first bad commit
> commit e09e9089131ca0227a716aee143f49d084977e32
> Author: Pavel Machek <pavel@ucw.cz>
> Date: Wed Nov 28 03:06:03 2007 +0100
>
> x86: fix wrong hpet values
> <----------------
it's the hpet_enable() returning non-0 that is causing the crash. The
current patch that is in x86.git is below.
Ingo
------------------->
Subject: x86: fix wrong hpet values
From: Pavel Machek <pavel@ucw.cz>
If hpet is not enabled in config, its init should not pretend to work,
and people should not try to get time from it.
Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
include/asm-x86/hpet.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: linux-x86.q/include/asm-x86/hpet.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/hpet.h
+++ linux-x86.q/include/asm-x86/hpet.h
@@ -82,8 +82,7 @@ extern irqreturn_t hpet_rtc_interrupt(in
#else
-static inline int hpet_enable(void) { return 0; }
-static inline unsigned long hpet_readl(unsigned long a) { return 0; }
+static inline int hpet_enable(void) { return -ENODEV; }
#endif /* CONFIG_HPET_TIMER */
#endif /* ASM_X86_HPET_H */
next prev parent reply other threads:[~2007-11-28 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 12:23 [patch] Fix hpet wrong values Pavel Machek
2007-11-28 2:53 ` Andrew Morton
2007-11-28 10:38 ` Ingo Molnar
2007-11-28 10:40 ` Ingo Molnar [this message]
2007-11-28 21:45 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128104040.GA20113@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox