public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ursula Braun <braunu@de.ibm.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Peter Tiedemann <ptiedem@de.ibm.com>
Subject: Re: [s390] networking related oops during boot on Hercules (was: build failure)
Date: Wed, 28 Nov 2007 18:05:33 +0100	[thread overview]
Message-ID: <200711281805.34959.elendil@planet.nl> (raw)
In-Reply-To: <200711281718.48661.borntraeger@de.ibm.com>

On Wednesday 28 November 2007, Christian Borntraeger wrote:
> This seems to be related to the new network namespace code by Eric
> Biederman (CCed). Can you try the following (untested) patch? I also
> CCed Ursula and Peter as they know the ctc code better than me.

Yes, that fixes it. Boots fine now and I can ssh into the system. Not tested 
any further than that.

Thanks Christian.

> CC: Eric W. Biederman <ebiederm@xmission.com>
> CC: Ursula Braun <braunu@de.ibm.com>
> CC: Peter Tiedemann <ptiedem@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> ---
>  drivers/s390/net/ctcmain.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/s390/net/ctcmain.c
> ===================================================================
> --- linux-2.6.orig/drivers/s390/net/ctcmain.c
> +++ linux-2.6/drivers/s390/net/ctcmain.c
> @@ -56,6 +56,7 @@
>  #include <linux/skbuff.h>
>  #include <linux/ctype.h>
>  #include <net/dst.h>
> +#include <net/net_namespace.h>
>
>  #include <asm/io.h>
>  #include <asm/ccwdev.h>
> @@ -2823,6 +2824,7 @@ ctc_init_netdevice(struct net_device * d
>  	dev->type = ARPHRD_SLIP;
>  	dev->tx_queue_len = 100;
>  	dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> +	dev->nd_net = &init_net;
>  	return dev;
>  }


  reply	other threads:[~2007-11-28 17:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28 10:27 [s390] build failure Frans Pop
2007-11-28 10:51 ` Christian Borntraeger
2007-11-28 11:05   ` Frans Pop
2007-11-28 12:24   ` [s390] networking related oops during boot on Hercules (was: build failure) Frans Pop
2007-11-28 16:18     ` Christian Borntraeger
2007-11-28 17:05       ` Frans Pop [this message]
2007-11-28 17:26       ` Eric W. Biederman
2007-11-28 18:42         ` Stephen Hemminger
2007-11-28 17:30       ` Ursula Braun
2007-11-28 11:03 ` [s390] build failure Martin Schwidefsky
2007-12-04 12:03   ` Frans Pop
2007-12-04 12:26     ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711281805.34959.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=borntraeger@de.ibm.com \
    --cc=braunu@de.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=ptiedem@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox