public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J.A. Magallón" <jamagallon@ono.com>
To: "Linux-Kernel, " <linux-kernel@vger.kernel.org>
Subject: void* arithmnetic
Date: Thu, 29 Nov 2007 01:05:31 +0100	[thread overview]
Message-ID: <20071129010531.22b3a71f@werewolf> (raw)

Hi all...

Since begin of the ages the build of the nvidia driver says things like
this:

include/asm/compat.h:210: warning: pointer of type 'void *' used in arithmetic

There are several of this warnings. The code in question for this example
is:

static __inline__ void __user *compat_alloc_user_space(long len)
{
    struct pt_regs *regs = task_pt_regs(current);
    return (void __user *)regs->rsp - len;
}

As this is dealing with mem blocks, I suppose it's counting in bytes, so
we could do something like:

   return (void __user *)((u8*)regs->rsp - len);

so the arithmetic knows how to inc/dec for each unity...
I think the warning is correct and that void* arithmetic is undefined in C,
isn't it ?

TIA

--
J.A. Magallon <jamagallon()ono!com>     \               Software is like sex:
                                         \         It's better when it's free
Mandriva Linux release 2008.1 (Cooker) for i586
Linux 2.6.23-jam01 (gcc 4.2.2 20070909 (4.2.2-0.RC.1mdv2008.0)) SMP PREEMPT
09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0

             reply	other threads:[~2007-11-29  0:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  0:05 J.A. Magallón [this message]
2007-11-29  0:22 ` void* arithmnetic Arnaldo Carvalho de Melo
2007-11-29  0:39 ` Jan Engelhardt
2007-11-29  1:19   ` Ming Lei
2007-11-29  7:38     ` Benny Halevy
2007-11-29 12:31       ` WANG Cong
2007-11-30 11:38         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129010531.22b3a71f@werewolf \
    --to=jamagallon@ono.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox