Re: [RFC] Sample kset/ktype/kobject implementation

Greg KH
2007-11-30T06:43:22Z

On Thu, Nov 29, 2007 at 05:11:35PM -0500, Alan Stern wrote:
> On Thu, 29 Nov 2007, Greg KH wrote:
>
> > > > > kobject_put(foo) is needed since it gets you through kobject_cleanup()
> > > > > where the name can be freed.
> > > >
> > > > No, kobject_register() should have handled that for us, right?
> > >
> > > kobject_register() doesn't do a kobject_put() if kobject_add() failed.
> >
> > Crap. If I can't get this code right in an example, the API is messed
> > up. Time to take Kay seriously and start to revamp the basic kobject
> > api :)
>
> The rule is simple enough. After calling kobject_register() you should
> always use kobject_put() -- even if kobject_register() failed.

Yes.

> In fact, after calling kobject_init() you should use kobject_put().
> The first rule follows from this one, since kobject_register() calls
> kobject_init() internally.

Yes, that makes sense, time to write it all down :)

thanks,

greg k-h