Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

Cornelia Huck
2007-11-30T09:31:30Z

On Thu, 29 Nov 2007 21:26:40 +0100,
Kay Sievers <kay.sievers@vrfy.org> wrote:

> On Thu, 2007-11-29 at 21:20 +0100, Kay Sievers wrote:
> > On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote:
> > > On Thu, 29 Nov 2007, Kay Sievers wrote:
>
> > > > > There's another good reason for not assigning the name in
> > > > > kobject_init(): Code that uses kobjects (like the driver core) doesn't
> > > > > set the name until later.
> > > >
> > > > That can be done at any stage, I guess. We will rip out the name in the
> > > > struct device anyway.
> > >
> > > Are you also going to change all the places in the kernel where the
> > > device name (.bus_id) isn't set until after device_initialize() has
> > > been called?

Hmpf, ccw does this as well...

> >
> > Yes, I already have a patch that does that for all stuff that was needed
> > on my boxes.
>
> To be exact, bus_id will be removed from the device, and the device name
> will be set and retrieved directly from the kobject.

I guess you'll have accessor functions for the bus id for use by higher
level code?