Re: [RFC] Sample kset/ktype/kobject implementation

Alan Stern
2007-11-30T14:51:42Z

On Fri, 30 Nov 2007, Dave Young wrote:

> > The rule is simple enough. After calling kobject_register() you should
> > always use kobject_put() -- even if kobject_register() failed.
> >
> > In fact, after calling kobject_init() you should use kobject_put().
> > The first rule follows from this one, since kobject_register() calls
> > kobject_init() internally.
> >
> Hi,
> The behavior is not very clear here, the root problem is that :
>
> 1. Should we call kobject_put so cleanup work can be done by refcount
> touch zero or call kfree every time after kobject_register failed?

Call kobject_put so that the cleanup work will be done when the
refcount goes to 0. Don't call kfree.

> 2. If kobject_put calling is true, should this be done in
> kobject_register error handling codes or by hand after
> kobject_register failed?

It should be done by hand after kobject_register fails. Otherwise
kobject_register would end up dropping a reference that it never
acquired.

Alan Stern