kobject_init rewrite

Greg KH
2007-11-29T21:55:26Z

On Thu, Nov 29, 2007 at 05:21:34PM +0100, Cornelia Huck wrote:
> Kay Sievers <kay.sievers@vrfy.org> wrote:
> > int kobject_init(struct kobject *kobj, struct kobj_type *type, const char *fmt, ...)
>
> Agreed. Better don't hide too much.

Ok, how about this function. If it errors out, it is free to just call
kfree() on the kobject. Seems simple enough to me, any objections? If
not, I'll go through and fix up the whole tree...

thanks,

greg k-h

-----------------

/**
* kobject_init - initialize a kobject structure
* @kobj: pointer to the kobject to initialize
* @ktype: pointer to the ktype for this kobject.
* @fmt: the name of the kobject
*
* This function will properly initialize a kobject such that it can then
* be passed to the kobject_add() call.
*
* If the function returns an error, the memory allocated by the kobject
* can be safely freed, no other functions need to be called.
*/
int kobject_init(struct kobject *kobj, struct kobj_type *ktype, const char *fmt, ...)
{
va_list args;
int retval;

if (!kobj)
return -EINVAL;

if (!ktype)
return -EINVAL;

WARN_ON(atomic_read(&kobj->kref.refcount));
kref_init(&kobj->kref);
INIT_LIST_HEAD(&kobj->entry);
kobj->ktype = ktype;

va_start(args, fmt);
retval = kobject_set_name_vargs(kobj, fmt, args);
va_end(args);

return retval;
}